Skip to content

build(deps): bump @nextcloud/router from 2.2.1 to 3.0.0 - #44425

Merged
dependabot[bot] merged 3 commits into
masterfrom
dependabot/npm_and_yarn/nextcloud/router-3.0.0
Mar 23, 2024
Merged

build(deps): bump @nextcloud/router from 2.2.1 to 3.0.0#44425
dependabot[bot] merged 3 commits into
masterfrom
dependabot/npm_and_yarn/nextcloud/router-3.0.0

Conversation

@dependabot

@dependabotdependabotBot commented on behalf of githubMar 23, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Bumps @nextcloud/router from 2.2.1 to 3.0.0.

Release notes

Sourced from @​nextcloud/router's releases.

v3.0.0

3.0.0 - 2024-02-01

Full Changelog

Enhancements

Fixed

Changed

Dependencies

New Contributors

Changelog

Sourced from @​nextcloud/router's changelog.

3.0.0 - 2024-02-01

Full Changelog

Enhancements

Fixed

Changed

Dependencies

New Contributors

Commits
  • 41d123f Merge pull request #571 from nextcloud-libraries/v2.3.0
  • d332fde 3.0.0
  • 49c9775 Merge pull request #570 from nextcloud-libraries/fix/webroot
  • 47c71c1 Merge pull request #565 from nextcloud-libraries/fix/cleanup
  • c0fe31f Merge pull request #569 from nextcloud-libraries/fix/readme
  • e0becaf fix: Optimize and modernize code
  • 7a2109f fix(getRootUrl)!: If not configured use first subdirectory as webroot instead...
  • d55dbc6 fix: Remove unreachable code
  • 4924071 fix: Make README a bit nicer by adding badges
  • 3f8327e Merge pull request #566 from nextcloud-libraries/fix/generate-filepath-type
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
dependabotBot requested a review from a teamMarch 23, 2024 02:22
@solracsf

solracsf commented Mar 23, 2024

Copy link
Copy Markdown
Member

/compile

@skjnldsv

skjnldsv commented Mar 23, 2024

Copy link
Copy Markdown
Member

@dependabot recreate

@dependabot
dependabotBotforce-pushed the dependabot/npm_and_yarn/nextcloud/router-3.0.0 branch from 4c5d34a to 9c6c9f2CompareMarch 23, 2024 15:06
@skjnldsv

skjnldsv commented Mar 23, 2024

Copy link
Copy Markdown
Member

/compile amend /

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 23, 2024
@nextcloud-command
nextcloud-commandforce-pushed the dependabot/npm_and_yarn/nextcloud/router-3.0.0 branch from 9c6c9f2 to f7e6cbfCompareMarch 23, 2024 15:10
@skjnldsv

skjnldsv commented Mar 23, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Seems related @susnux

FAIL apps/files/src/actions/favoriteAction.spec.ts
● Favorite action execute tests › Favorite triggers tag addition
expect(jest.fn()).toBeCalledWith(...expected)
- Expected
+ Received
- "/index.php/apps/files/api/v1/files/foobar.txt",
+ "//index.php/apps/files/api/v1/files/foobar.txt",
{"tags": ["_$!<Favorite>!$_"]},
Number of calls: 1
161 | // Check POST request
162 | expect(axios.post).toBeCalledTimes(1)
> 163 | expect(axios.post).toBeCalledWith('/index.php/apps/files/api/v1/files/foobar.txt', { tags: ['_$!<Favorite>!$_'] })
| ^
164 |
165 | // Check node change propagation
166 | expect(file.attributes.favorite).toBe(1)
at Object.<anonymous> (apps/files/src/actions/favoriteAction.spec.ts:163:22)

@skjnldsvskjnldsv added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Mar 23, 2024
@susnux

susnux commented Mar 23, 2024

Copy link
Copy Markdown
Contributor

Yes because of missing mock of oc

@susnux

susnux commented Mar 23, 2024

Copy link
Copy Markdown
Contributor

@dependabot recreate

@dependabot
dependabotBotforce-pushed the dependabot/npm_and_yarn/nextcloud/router-3.0.0 branch from f7e6cbf to 19ea02cCompareMarch 23, 2024 17:54
@dependabot@susnux
build(deps): bump @nextcloud/router from 2.2.1 to 3.0.0
20d069b
Bumps [@nextcloud/router](https://github.com/nextcloud/nextcloud-router) from 2.2.1 to 3.0.0.
- [Release notes](https://github.com/nextcloud/nextcloud-router/releases)
- [Changelog](https://github.com/nextcloud-libraries/nextcloud-router/blob/master/CHANGELOG.md)
- [Commits](nextcloud-libraries/nextcloud-router@v2.2.1...v3.0.0)
---
updated-dependencies:
- dependency-name: "@nextcloud/router"
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
susnuxforce-pushed the dependabot/npm_and_yarn/nextcloud/router-3.0.0 branch from 19ea02c to 20d069bCompareMarch 23, 2024 18:12
@skjnldsv

skjnldsv commented Mar 23, 2024

Copy link
Copy Markdown
Member

Related 💪 🔧

 OC.L10N tests
async loading of translations
✗ loads bundle for given app and calls callback
Expected 'undefined/l10n/zh_CN.json' to equal 'http://localhost/apps3/jsunittestapp/l10n/zh_CN.json'.
at core/js/tests/specs/l10nSpec.js:128:22

@susnux
fix(tests): Add mock for window._oc_webroot
fef9fb3
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
15a85f0
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the dependabot/npm_and_yarn/nextcloud/router-3.0.0 branch from c9777dc to 15a85f0CompareMarch 23, 2024 19:48
@susnux

susnux commented Mar 23, 2024

Copy link
Copy Markdown
Contributor

Yes another instance of legacy tests doing legacy stuff without mocking all legacy objects ;)

Mocking OC.appwebroots is not enough as the router now uses _oc_webroots directly.

@susnux

susnux commented Mar 23, 2024

Copy link
Copy Markdown
Contributor

@dependabot merge

@dependabot
dependabotBot merged commit b0ad69d into masterMar 23, 2024
@dependabot
dependabotBot deleted the dependabot/npm_and_yarn/nextcloud/router-3.0.0 branch March 23, 2024 20:59
@AltahrimAltahrim mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsvskjnldsvskjnldsv approved these changes
@github-actionsgithub-actions[bot]github-actions[bot] approved these changes

Assignees

No one assigned

Labels

2. developingWork in progressfeature: dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@solracsf@skjnldsv@susnux