Skip to content

fix(contactsinteraction): Allow vCard download - #44457

Merged
Altahrim merged 1 commit into
masterfrom
fix/contactsinteraction/download-vcard
Mar 26, 2024
Merged

fix(contactsinteraction): Allow vCard download#44457
Altahrim merged 1 commit into
masterfrom
fix/contactsinteraction/download-vcard

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Mar 25, 2024

Copy link
Copy Markdown
Member

Summary

Sabre calculates a header for the size of a vcard, therefore we have to implement the size method.

How to test

  1. Share a file to an email address
  2. Open Contacts and find a generated contact for the email address
  3. Open the contact details
  4. Click on the actions menu in the top right
  5. Click Download

Master: nothing happens (URL is opened in a new tab and kind of silently fails).
Here: vcard is downloaded.

Checklist

@ChristophWurstChristophWurst added this to the Nextcloud 29 milestone Mar 25, 2024
@ChristophWurstChristophWurst self-assigned this Mar 25, 2024
miaulalala
miaulalala approved these changes Mar 25, 2024
View reviewed changes

@miaulalalamiaulalala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxence

@AltahrimAltahrim mentioned this pull request Mar 26, 2024
Merged
Altahrim
Altahrim reviewed Mar 26, 2024
View reviewed changes
Comment threadapps/contactsinteraction/lib/Card.php Outdated
@ChristophWurst
ChristophWurstforce-pushed the fix/contactsinteraction/download-vcard branch from a74f440 to e80fc99CompareMarch 26, 2024 12:59
@ChristophWurst
fix(contactsinteraction): Allow vCard download
b8250af
Sabre calculates a header for the size of a vcard, therefore we have to
implement the size method.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
ChristophWurstforce-pushed the fix/contactsinteraction/download-vcard branch from e80fc99 to b8250afCompareMarch 26, 2024 13:41
@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 26, 2024
@Altahrim
Altahrim merged commit 5a6e6a1 into masterMar 26, 2024
@Altahrim
Altahrim deleted the fix/contactsinteraction/download-vcard branch March 26, 2024 19:18
@AltahrimAltahrim removed the 4. to release Ready to be released and/or waiting for tests to finish label Mar 26, 2024
@ChristophWurst

ChristophWurst commented Mar 26, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@ChristophWurst

ChristophWurst commented Mar 26, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@ChristophWurst

ChristophWurst commented Mar 26, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

@ChristophWurst

ChristophWurst commented May 13, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@backportbotbackportbotBot mentioned this pull request May 13, 2024
Merged
@ChristophWurst

ChristophWurst commented May 22, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@backportbotbackportbotBot mentioned this pull request May 22, 2024
Merged
@backportbotbackportbotBot mentioned this pull request May 22, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AltahrimAltahrimAltahrim approved these changes
@miaulalalamiaulalalamiaulalala approved these changes
@hamza221hamza221Awaiting requested review from hamza221
@GVodyanovGVodyanovAwaiting requested review from GVodyanov

Assignees

@ChristophWurstChristophWurst

Labels

bugfeature: carddavRelated to CardDAV internalsfeature: contactsfeature: dav

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

3 participants

@ChristophWurst@Altahrim@miaulalala