Skip to content

feat: add interface for lower level filecache acess without having to do direct db queries - #44458

Merged
icewind1991 merged 1 commit into
masterfrom
fileacces-interface
Mar 25, 2024
Merged

feat: add interface for lower level filecache acess without having to do direct db queries#44458
icewind1991 merged 1 commit into
masterfrom
fileacces-interface

Conversation

@icewind1991

@icewind1991icewind1991 commented Mar 25, 2024

Copy link
Copy Markdown
Member

Adds and interface for the filecache that is lower level than the "normal" filesystem apis to allow for some more optimized retrieval of filecache data without requiring direct database access.

This will be needed when we start restricting direct database access to the filecache for sharding.

Split from #44044

@icewind1991icewind1991 added the 3. to review Waiting for reviews label Mar 25, 2024
@icewind1991icewind1991 added this to the Nextcloud 29 milestone Mar 25, 2024
come-nc
come-nc reviewed Mar 25, 2024
View reviewed changes

@come-nccome-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Comment threadlib/private/Files/Cache/FileAccess.php
Comment threadlib/private/Files/Cache/FileAccess.php Outdated
Comment threadlib/private/Files/Cache/FileAccess.php Outdated
Comment threadlib/private/Files/Cache/FileAccess.php Outdated
Comment threadlib/public/Files/Cache/IFileAccess.php
Comment threadlib/public/Files/Cache/IFileAccess.php Outdated
Comment threadlib/public/Files/Cache/IFileAccess.php Outdated
come-nc
come-nc approved these changes Mar 25, 2024
View reviewed changes
Comment threadlib/public/Files/Cache/IFileAccess.php Outdated
@icewind1991
feat: add interface for lower level filecache acess without having to…
1d9354a
… do direct db queries
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991 merged commit ae19e94 into masterMar 25, 2024
@icewind1991
icewind1991 deleted the fileacces-interface branch March 25, 2024 16:28
@AltahrimAltahrim mentioned this pull request Mar 26, 2024
Merged
@artongeartonge mentioned this pull request May 22, 2024
Closed
45 tasks
@icewind1991icewind1991 mentioned this pull request May 22, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artongeartongeartonge approved these changes
@come-nccome-ncAwaiting requested review from come-nc

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@artonge@come-nc