Uh oh!
There was an error while loading. Please reload this page.
[stable28] enh: Send empty expireDate when not expireDate set - #44490
Merged
Conversation
emoral435
approved these changes
Mar 26, 2024
emoral435
left a comment
Contributor
There was a problem hiding this comment.
Also just needs a compile :)
emoral435
commented
Mar 26, 2024
Contributor
/compile |
emoral435
commented
Mar 26, 2024
Contributor
now just needs to update commit message and update message :) |
nfebe
approved these changes
Mar 26, 2024
nfebe
marked this pull request as ready for review
March 26, 2024 17:08
Merged
nfebeforce-pushed
the
backport/44291/stable28
branch
from
April 15, 2024 21:52
5dc1913 to
c616dffComparenfebe
commented
Apr 15, 2024
Contributor
/compile amend |
nextcloud-commandforce-pushed
the
backport/44291/stable28
branch
from
April 15, 2024 22:01
c616dff to
4a6f904CompareWhen creating a new share, if the user unchecks "Set expiry date" no `expireDate` is sent to the server. However, the server then assumes the default configured, hence better to send an empty value. Signed-off-by: fenn-cs <fenn25.fn@gmail.com> [skip ci]
nfebeforce-pushed
the
backport/44291/stable28
branch
from
April 16, 2024 08:51
4a6f904 to
713f266Comparenfebe
commented
Apr 16, 2024
Contributor
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #44291
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.