Uh oh!
There was an error while loading. Please reload this page.
[stable28] fix(share): Send correct share attributes upon share creation - #44500
Merged
Conversation
nfebeforce-pushed
the
backport/44484/stable28
branch
from
March 27, 2024 13:32
ad6597f to
96066d1Comparenfebe
approved these changes
Mar 27, 2024
nfebe
marked this pull request as ready for review
March 27, 2024 13:45
Merged
emoral435force-pushed
the
backport/44484/stable28
branch
from
March 29, 2024 21:45
96066d1 to
63d2f7eCompareemoral435
approved these changes
Mar 29, 2024
emoral435
left a comment
Contributor
There was a problem hiding this comment.
PR is now complete - just needs a compile. Will approve this PR so once freeze over, this can get merged whenever! :)
susnuxforce-pushed
the
backport/44484/stable28
branch
from
March 29, 2024 23:13
63d2f7e to
94d946cComparesusnux
commented
Mar 29, 2024
Contributor
/compile |
susnux
enabled auto-merge
March 29, 2024 23:13
susnux
commented
Mar 29, 2024
Contributor
Freeze is over since Thursday :) |
emoral435force-pushed
the
backport/44484/stable28
branch
from
April 1, 2024 14:35
10edf36 to
3b2726bCompareAltahrim
commented
Apr 17, 2024
Collaborator
Conflicts here :) |
Merged
nfebeforce-pushed
the
backport/44484/stable28
branch
from
April 26, 2024 19:58
3b2726b to
8e97c6dCompare- Send correct share attributes (`share.attributes`) to server upon creation. - Delete parts of code that create or reference, `share.hasDownloadPermission` (Not required by Share API) Resolves : #44131 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: Eduardo Morales <emoral435@gmail.com>
nfebeforce-pushed
the
backport/44484/stable28
branch
from
April 26, 2024 20:00
8e97c6d to
bbb28fdComparenfebe
commented
Apr 26, 2024
Contributor
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #44484
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.