Skip to content

fix(appconfig): format app values - #44644

Merged
susnux merged 2 commits into
masterfrom
enh/noid/returns-formated-app-values
Apr 17, 2024
Merged

fix(appconfig): format app values#44644
susnux merged 2 commits into
masterfrom
enh/noid/returns-formated-app-values

Conversation

@ArtificialOwl

@ArtificialOwlArtificialOwl commented Apr 4, 2024

Copy link
Copy Markdown
Member

returns formated values based on type when calling getAllValues() and searchValues()

note: deprecated method getValues() use getAllValues() but if the config value is defined as MIXED (default), the value is kept as a string.

original:

{
"key1": "value1",
"key2": "value0",
"key6": "1",
"key7": "{\"test1\":1,\"test2\":2}",
"test8": "1",
"key3": "value0",
"key4": "3",
"key5": "3.14"
}

new:

{
"key1": "value1",
"key2": "value0",
"key6": true,
"key7": {
"test1": 1,
"test2": 2
},
"test8": true,
"key3": "value0",
"key4": 3,
"key5": 3.14
}

same as #43258 with tests

@ArtificialOwlArtificialOwl added the 3. to review Waiting for reviews label Apr 4, 2024
@ArtificialOwlArtificialOwl added this to the Nextcloud 29 milestone Apr 4, 2024
@ArtificialOwl
ArtificialOwl requested review from a team, nfebe, skjnldsv and sorbaugh and removed request for a teamApril 4, 2024 01:33
@ArtificialOwl

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

Comment threadlib/private/AppConfig.php Outdated
Comment threadlib/private/AppConfig.php Outdated
@blizzzblizzz mentioned this pull request Apr 4, 2024
67 tasks
@ArtificialOwl
ArtificialOwlforce-pushed the enh/noid/returns-formated-app-values branch 3 times, most recently from cffdaed to 40d7716CompareApril 4, 2024 18:45
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl
ArtificialOwlforce-pushed the enh/noid/returns-formated-app-values branch from 40d7716 to 97e59b1CompareApril 5, 2024 18:49
@blizzzblizzz mentioned this pull request Apr 8, 2024
67 tasks
@blizzzblizzz modified the milestones: Nextcloud 29, Nextcloud 30Apr 8, 2024
@susnux
susnux merged commit 3aa9c53 into masterApr 17, 2024
@susnux
susnux deleted the enh/noid/returns-formated-app-values branch April 17, 2024 15:11
@blizzzblizzz mentioned this pull request Jul 24, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ArtificialOwl@susnux@come-nc@blizzz