Skip to content

fix(caldav): When message is a reply compare the message sender not the recipient - #44893

Merged
kesselb merged 1 commit into
masterfrom
fix/issue-43115
Jun 26, 2024
Merged

fix(caldav): When message is a reply compare the message sender not the recipient#44893
kesselb merged 1 commit into
masterfrom
fix/issue-43115

Conversation

@SebastianKrupinski

@SebastianKrupinskiSebastianKrupinski commented Apr 17, 2024

Copy link
Copy Markdown
Contributor

Summary

When message is a reply compare the message sender not the recipient.

@solracsfsolracsf changed the title fix: for issue #43115fix(caldav): When message is a reply compare the message sender not the recipientApr 17, 2024
@susnuxsusnux added this to the Nextcloud 30 milestone Apr 18, 2024
ChristophWurst
ChristophWurst reviewed Apr 18, 2024
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & works

Could you please extend \OCA\DAV\Tests\unit\CalDAV\Schedule\IMipPluginTest for three tests that cover the three possible paths of \OCA\DAV\CalDAV\Schedule\IMipService::getCurrentAttendee? 1. Reply, 2. invite, 3. no match.

Comment threadapps/dav/lib/CalDAV/Schedule/IMipService.php Outdated
Comment on lines +575 to +576
}
elseif (strcasecmp($attendee->getValue(), $iTipMessage->recipient) === 0) {

@ChristophWurstChristophWurstApr 18, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
elseif (strcasecmp($attendee->getValue(), $iTipMessage->recipient) === 0) {
} elseif (strcasecmp($attendee->getValue(), $iTipMessage->recipient) === 0) {

@ChristophWurst

ChristophWurst commented Apr 18, 2024

Copy link
Copy Markdown
Member

/backport to stable29

@ChristophWurst

ChristophWurst commented Apr 18, 2024

Copy link
Copy Markdown
Member

/backport to stable28

@ChristophWurst

ChristophWurst commented Apr 23, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Could you please extend \OCA\DAV\Tests\unit\CalDAV\Schedule\IMipPluginTest for three tests that cover the three possible paths of \OCA\DAV\CalDAV\Schedule\IMipService::getCurrentAttendee? 1. Reply, 2. invite, 3. no match.

I'm sorry, I mixed up the classes. We want to unit test \OCA\DAV\CalDAV\Schedule\IMipService::getCurrentAttendee so the tests will go into \OCA\DAV\Tests\unit\CalDAV\Schedule\IMipServiceTest

Move the tests please

@kesselb

kesselb commented Jun 25, 2024

Copy link
Copy Markdown
Contributor

/backport to stable27

@kesselbkesselb added bug 3. to review Waiting for reviews labels Jun 25, 2024
@SebastianKrupinski
fix(caldav): when message is a reply compare the message sender not t…
d7eb509
…he recipient
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
kesselb merged commit aa0bbd2 into masterJun 26, 2024
@kesselb
kesselb deleted the fix/issue-43115 branch June 26, 2024 16:58
This was referenced Jun 26, 2024
Merged
Merged
Merged
This was referenced Jul 1, 2024
Closed
Closed
@flortschflortsch mentioned this pull request Jul 9, 2024
Open
9 tasks
@SebastianKrupinskiSebastianKrupinski mentioned this pull request Jul 18, 2024
Closed
9 tasks
@blizzzblizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselbkesselbkesselb approved these changes
@miaulalalamiaulalalamiaulalala approved these changes
@tcitworldtcitworldAwaiting requested review from tcitworldtcitworld is a code owner
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurstChristophWurst is a code owner

Assignees

@SebastianKrupinskiSebastianKrupinski

Labels

3. to reviewWaiting for reviewsbug

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

[Bug]: Nextcloud 28 don't send notification when accept a meeting

5 participants

@SebastianKrupinski@ChristophWurst@kesselb@miaulalala@susnux