Uh oh!
There was an error while loading. Please reload this page.
fix(files): Retry deleting a file if currently locked - #44901
Closed
susnux wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
commented
Apr 17, 2024
ContributorAuthor
/backport to stable29 |
Pytal
reviewed
Apr 17, 2024
Pytal
left a comment
Member
There was a problem hiding this comment.
This would mean that a deletion would be retried infinitely until page reload in the case that the file never unlocks? Seems strange and would be better to just tell the user to retry in 10s or contact sysadmin no?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #44631
Summary
If a file is currently locked, wait and retry the delete operation.
Also add a user message so to inform the user.
Checklist