Skip to content

[stable27] fix(files): Also restore shares after ownership transfer for object storage - #44920

Merged
Altahrim merged 1 commit into
stable27from
backport/44904/stable27
Apr 18, 2024
Merged

[stable27] fix(files): Also restore shares after ownership transfer for object storage#44920
Altahrim merged 1 commit into
stable27from
backport/44904/stable27

Conversation

@backportbot

@backportbotbackportbotBot commented Apr 18, 2024

Copy link
Copy Markdown

Backport of #44904

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbotbackportbotBot added this to the Nextcloud 27.1.9 milestone Apr 18, 2024
@susnux
susnux marked this pull request as ready for review April 18, 2024 14:00
…torage
When a file is moved between different storages then the file id is not (always) preserved.
This means the file id has to be adjusted for all shares.
So in case the file id does not exist anymore we try to find the new file id based on the
target path of the transfer and the path suffix of the share.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the backport/44904/stable27 branch from 87c52a2 to a5e8727CompareApril 18, 2024 14:05
@AltahrimAltahrim mentioned this pull request Apr 18, 2024
4 tasks
string $destinationUid,
array $shares,
OutputInterface $output) {
private function restoreShares(

Check notice

Code scanning / Psalm

MissingReturnType

Method OCA\Files\Service\OwnershipTransferService::restoreShares does not have a return type, expecting void
@Altahrim
Altahrim merged commit 129e9fd into stable27Apr 18, 2024
@Altahrim
Altahrim deleted the backport/44904/stable27 branch April 18, 2024 19:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@susnux@Altahrim@artonge@github-advanced-security