Uh oh!
There was an error while loading. Please reload this page.
fix(settings): Save one HTTP request on enabling an app - #44939
Merged
Conversation
susnux
requested review from
a team, emoral435, sorbaugh and szaimen
and removed request for
a teamApril 19, 2024 20:04
susnux
commented
Apr 19, 2024
ContributorAuthor
/backport to stable29 |
susnux
commented
Apr 19, 2024
ContributorAuthor
/backport to stable28 |
szaimen
approved these changes
Apr 19, 2024
szaimen
left a comment
Contributor
There was a problem hiding this comment.
Not exactly sure how this helps but fine by me
susnux
commented
Apr 19, 2024
ContributorAuthor
We prevent the 301 HTTP response for |
emoral435
approved these changes
Apr 20, 2024
8 tasks
…ng slash This prevents one HTTP request for most situations (301 from `apps/files` to `apps/files/`) and helps users with faulty reverse-proxy configuration. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
nfebe
approved these changes
May 6, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This prevents one HTTP request for most situations (301 from
apps/filestoapps/files/) and helps users with faulty reverse-proxy configuration.Checklist