Uh oh!
There was an error while loading. Please reload this page.
fix(OC_Image): Set correct return type for exif_imagetype stub - #45196
Merged
Conversation
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
requested review from
andrey18106, bigcat88, julien-nc and marcelklehrMay 6, 2024 11:34
provokateurin
commented
May 6, 2024
MemberAuthor
/backport to stable29 |
provokateurin
commented
May 6, 2024
MemberAuthor
/backport to stable28 |
provokateurin
commented
May 6, 2024
MemberAuthor
/backport to stable27 |
bigcat88
approved these changes
May 6, 2024
marcelklehr
approved these changes
May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The proper method returns
int|falseand the stub should do the same. I only noticed it now because psalm started complaining that$info[2]is notstring|booleanbutint|falselike expected.Checklist