Skip to content

fix(files): do not rely on unique fileid - #45251

Merged
AndyScherzinger merged 3 commits into
masterfrom
fix/files-source-no-fileid
Jun 12, 2024
Merged

fix(files): do not rely on unique fileid#45251
AndyScherzinger merged 3 commits into
masterfrom
fix/files-source-no-fileid

Conversation

@skjnldsv

@skjnldsvskjnldsv commented May 10, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Fix the rendering of duplicates fileids in the Files app

How to

  1. Create a local external storage
  2. Create a second one wih the exact same path
  3. Open the Files app
  4. See an error in the log and scrolling starts to break

Solution

  • We do not store files by their ID anymore
  • Once we receive a node event, we will use the node payload as a source of truth ONLY if we have one entry in the store. If we don't we fetch the node data in the dav backend to refresh the content. This is an edge case, so the perf loss is accepted here

@skjnldsv
skjnldsvforce-pushed the fix/files-source-no-fileid branch from 963ee41 to 677783aCompareMay 10, 2024 12:14
@skjnldsv
fix(files): do not rely on unique fileid
1d7893d
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the fix/files-source-no-fileid branch from 677783a to 1d7893dCompareJune 12, 2024 15:16
@skjnldsv
skjnldsv marked this pull request as ready for review June 12, 2024 15:51
@skjnldsv
skjnldsvforce-pushed the fix/files-source-no-fileid branch from eddf1f7 to 251503bCompareJune 12, 2024 15:55
@skjnldsv
skjnldsv requested review from a team, Pytal, artonge, nfebe and susnux and removed request for a teamJune 12, 2024 15:55
@skjnldsvskjnldsv self-assigned this Jun 12, 2024
@skjnldsvskjnldsv added this to the Nextcloud 30 milestone Jun 12, 2024
@skjnldsv

skjnldsv commented Jun 12, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@skjnldsv

skjnldsv commented Jun 12, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@skjnldsv
fix(files): fetch nodes if we have multiple of the same fileid in the…
343b690
… store
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the fix/files-source-no-fileid branch from 251503b to 343b690CompareJune 12, 2024 15:57
@AndyScherzinger

AndyScherzinger commented Jun 12, 2024

Copy link
Copy Markdown
Member

/compile /

@nextcloud-command
chore(assets): Recompile assets
51791e5
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnux
susnux approved these changes Jun 12, 2024
View reviewed changes

@susnuxsusnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘 🧹

@AndyScherzinger
AndyScherzinger merged commit 7093472 into masterJun 12, 2024
@AndyScherzinger
AndyScherzinger deleted the fix/files-source-no-fileid branch June 12, 2024 20:54
This was referenced Jun 12, 2024
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Jun 13, 2024
Closed
8 tasks
@blizzzblizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzingerAndyScherzingerAndyScherzinger approved these changes
@susnuxsusnuxsusnux approved these changes
@artongeartongeAwaiting requested review from artonge
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-frontend
@PytalPytalAwaiting requested review from Pytal

Assignees

@skjnldsvskjnldsv

Labels

3. to reviewWaiting for reviewsbugfeature: filestechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@AndyScherzinger@susnux@nextcloud-command