Skip to content

[stable28] Avoid updating the same oc_authtoken row twice - #45349

Merged
kesselb merged 3 commits into
stable28from
backport/45026/stable28
Jun 2, 2024
Merged

[stable28] Avoid updating the same oc_authtoken row twice#45349
kesselb merged 3 commits into
stable28from
backport/45026/stable28

Conversation

@backportbot

@backportbotbackportbotBot commented May 16, 2024•
edited by kesselb
Loading

Copy link
Copy Markdown

@backportbotbackportbotBot added this to the Nextcloud 28.0.6 milestone May 16, 2024
@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 16, 2024
ChristophWurst
ChristophWurst previously requested changes May 16, 2024
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#45026 (comment)

@ChristophWurstChristophWurst added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels May 21, 2024
@ChristophWurst
ChristophWurst marked this pull request as draft May 21, 2024 06:17
@kesselb
kesselbforce-pushed the backport/45026/stable28 branch from f860af1 to 4a215fbCompareMay 29, 2024 12:00
@kesselb

kesselb commented May 29, 2024

Copy link
Copy Markdown
Contributor

Rebased the pull request on #45063 and cherry-picked #45411.

@kesselb
kesselb marked this pull request as ready for review May 29, 2024 12:02
@kesselb
kesselbforce-pushed the backport/45026/stable28 branch from 4a215fb to 29665efCompareMay 29, 2024 12:04
@kesselb

kesselb commented May 29, 2024

Copy link
Copy Markdown
Contributor

Merged #45063 and rebased again.

@kesselbkesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 29, 2024
juliusknorrand others added 3 commits May 31, 2024 17:30
@juliusknorr@kesselb
docs: Update token_auth_activity_update default value to match implem…
9b14de0
…entation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr@kesselb
fix: Always set last activity if we update the row of an authtoken an…
41528b1
…yways
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@ChristophWurst@kesselb
fix(auth): Update authtoken activity selectively
9880800
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@kesselb
kesselbforce-pushed the backport/45026/stable28 branch from 29665ef to 9880800CompareMay 31, 2024 15:30
@kesselbkesselb added 4. to release Ready to be released and/or waiting for tests to finish 3. to review Waiting for reviews and removed 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish labels May 31, 2024
@kesselb
kesselb merged commit aac7365 into stable28Jun 2, 2024
@kesselb
kesselb deleted the backport/45026/stable28 branch June 2, 2024 20:06
@blizzzblizzz mentioned this pull request Jun 11, 2024
Merged
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AltahrimAltahrimAltahrim approved these changes
@kesselbkesselbkesselb approved these changes
@joshtrichardsjoshtrichardsAwaiting requested review from joshtrichards
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst

Assignees

@juliusknorrjuliusknorr

Labels

3. to reviewWaiting for reviewsenhancementfeature: authenticationperformance 🚀

Projects

None yet

Milestone

Nextcloud 28.0.7

Development

Successfully merging this pull request may close these issues.

5 participants

@kesselb@ChristophWurst@Altahrim@AndyScherzinger@juliusknorr