Uh oh!
There was an error while loading. Please reload this page.
fix(user_ldap): Do not map groups we do not know if they match filter - #45364
Merged
Conversation
come-nc
marked this pull request as draft
May 16, 2024 12:43
6 tasks
come-ncforce-pushed
the
fix/ldap-avoid-false-positive-mapping
branch
from
January 27, 2025 11:39
64c97b4 to
647a79aCompareWhen nesting is enabled, filterValidGroups is supposed to check for each groups if it actually exist, because it may not be visible to Nextcloud. So in this codepath we disable automapping of groups. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-ncforce-pushed
the
fix/ldap-avoid-false-positive-mapping
branch
from
January 27, 2025 13:51
647a79a to
de77415Comparecome-nc
marked this pull request as ready for review
January 27, 2025 13:52
come-nc
commented
Jan 27, 2025
ContributorAuthor
/backport to stable31 |
come-nc
commented
Jan 27, 2025
ContributorAuthor
/backport to stable30 |
come-nc
commented
Jan 27, 2025
ContributorAuthor
/backport to stable29 |
provokateurin
approved these changes
Jan 27, 2025
artonge
approved these changes
Jan 27, 2025
This was referenced Jan 27, 2025
This was referenced Mar 4, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When nesting is enabled, filterValidGroups is supposed to check for each groups if it actually exist, because it may not be visible to Nextcloud. So in this codepath we disable automapping of groups.
That may mean in some cases we do not map a valid group, but it should get mapped sooner or later anyway.
I’m still pondering if this is the best solution.Maybe only do that if nesting is enabled? Not clear to me yet if this is the only possible problematic caseMaybe only do that if$nameis not null, as when it isnulla search will be used to validate existence anyway.If this last point is true, maybe we simply always passnullfor$name? Or passnullfor$namewhen nesting is enabled?Checklist