Uh oh!
There was an error while loading. Please reload this page.
fix(Collaboration): Allow to enforce strict email format on sharees API - #45425
Closed
susnux wants to merge 1 commit into
Closed
fix(Collaboration): Allow to enforce strict email format on sharees API#45425susnux wants to merge 1 commit into
susnux wants to merge 1 commit into
Conversation
susnux
commented
May 21, 2024
ContributorAuthor
@AndyScherzinger this would fix the email share issue |
susnux
marked this pull request as ready for review
May 21, 2024 19:04
susnuxforce-pushed
the
fix/allow-strict-email
branch
from
May 21, 2024 19:04
1070d96 to
0c0e296Comparesusnux
commented
May 21, 2024
ContributorAuthor
Should we add an UI toggle? |
AndyScherzinger
commented
May 21, 2024
Member
Don't think that is needed. A config value is just fine. This is nothing that gets changed, you chose one or the other (forever) I suppose. |
Uh oh!
There was an error while loading. Please reload this page.
Only recommend a email address as sharee if it satisfies the strict format checking. Meaning before `a@b` was valid, while now with strict checking it is invalid and needs to be at least `a@b.c` Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
fix/allow-strict-email
branch
from
May 22, 2024 10:07
136bfef to
a08575cCompareAltahrim
approved these changes
May 22, 2024
come-nc
approved these changes
May 23, 2024
come-nc
left a comment
Contributor
There was a problem hiding this comment.
A bit weird that the config switch only applies to shareapi and not more globally to email validation.
susnux
commented
May 28, 2024
ContributorAuthor
@come-nc should I change this? I would be fine with that. Would be even more clean :) |
susnux
commented
May 29, 2024
ContributorAuthor
See: #45570 |
susnux
commented
Jun 4, 2024
ContributorAuthor
Closed in favor of #45570 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Only recommend a email address as sharee if it satisfies the strict format checking. Meaning before
a@bwas valid, while now with strict checking it is invalid and needs to be at leasta@b.cScreenshots
Checklist