Uh oh!
There was an error while loading. Please reload this page.
fix(theming): replace standard generic package icon by material design - #45480
Merged
Conversation
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
marcoambrosini
approved these changes
May 23, 2024
susnux
approved these changes
May 27, 2024
skjnldsv
commented
May 30, 2024
MemberAuthor
/backport to stable29 |
skjnldsv
commented
May 30, 2024
MemberAuthor
/backport to stable28 |
susnux
commented
May 30, 2024
Contributor
BTW if the icon has |
skjnldsv
commented
May 30, 2024
MemberAuthor
yeah, I think we need to discuss what we really want to do with the theming mime colour api. I'm not sure this is really relevant anymore 🤔 |
skjnldsv
commented
May 30, 2024
MemberAuthor
Discussion: #45579 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #42517
Considering we have replaced the office icons and other filetypes are the standard grey color, ket's replace that old
#0082c9Nextcloud blue by the same#969696grey.I also used that opportunity to update the icon from the material design, like it was done with others in the last months.
cc @nextcloud/designers