Skip to content

fix(core): unsupported browser redirect url - #45494

Merged
skjnldsv merged 2 commits into
masterfrom
fix/unsupported-redirect
Jun 2, 2024
Merged

fix(core): unsupported browser redirect url#45494
skjnldsv merged 2 commits into
masterfrom
fix/unsupported-redirect

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

Fix#43142

To easily try this, just use a php webserver on a freshly cloned server repo

@skjnldsvskjnldsv added bug 3. to review Waiting for reviews labels May 24, 2024
@skjnldsvskjnldsv added this to the Nextcloud 30 milestone May 24, 2024
@skjnldsvskjnldsv self-assigned this May 24, 2024
@skjnldsv
skjnldsv requested review from a team, Pytal, sorbaugh and szaimen and removed request for a teamMay 24, 2024 09:11
@szaimen

Copy link
Copy Markdown
Contributor

Hey @skjnldsv I'd like to test this but don't know how to get an unsupported browser onto my PC. Do you have any idea which browser I could try?

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

but don't know how to get an unsupported browser onto my PC.

On the dev tools you can change the user agent into the "other network conditions". You can select and edit a chrome version for example
image

@skjnldsv
skjnldsv requested a review from artongeMay 24, 2024 11:32

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

@PytalPytal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to work when there is a webroot e.g. "/nextcloud" 🤔

@skjnldsv
skjnldsvforce-pushed the fix/unsupported-redirect branch from f912966 to 6201adaCompareMay 30, 2024 13:44
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

image
Fixed @Pytal

@skjnldsv
skjnldsv requested a review from PytalMay 30, 2024 13:46

@PytalPytal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a quickfix, ReferenceError: getRootUrl is not defined 🙈

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the fix/unsupported-redirect branch from 6cc228d to 18539bbCompareJune 1, 2024 07:34
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/compile amend-rebase /

@nextcloud-command
nextcloud-commandforce-pushed the fix/unsupported-redirect branch from 18539bb to 6b8c3afCompareJune 1, 2024 07:42
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 1, 2024
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv
skjnldsvforce-pushed the fix/unsupported-redirect branch from 6b8c3af to 1a8f0c9CompareJune 2, 2024 08:52
@skjnldsv
skjnldsv merged commit d045482 into masterJun 2, 2024
@skjnldsv
skjnldsv deleted the fix/unsupported-redirect branch June 2, 2024 10:17
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@backportbot

Copy link
Copy Markdown

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/45494/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick fc3ee655 1a8f0c92
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45494/stable29

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/45494/stable29."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@blizzzblizzz mentioned this pull request Jul 24, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Wrong redirection with the button Continue with this unsupported browser

3 participants

@skjnldsv@szaimen@Pytal