feature: Improved Recurrence Invitations Messages

[SebastianKrupinski]

• Resolves: [Bug]: Event update email unclear with recurrence exceptions #38686

Summary

Improved Recurrence Invitations Messages

[github-advanced-security]

Psalm found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

[SebastianKrupinski]

TODO: unit tests

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[st3iny]

In general there are a lot of ternary operators. I'm not a big fan because they sacrifice readability for brevity.

I tagged the ones that are a bit problematic from my point of view. I'd also prefer some of the others to be refactored to regular if statements but have no hard opinions.

E.g. there are a lot of return cond ? a : b constructs.

---

It would also be nice to have some exemplary screenshots of the new messages or concrete steps for testing.

[SebastianKrupinski]

It would also be nice to have some exemplary screenshots of the new messages or concrete steps for testing.

For testing just create a new calendar event with at least one attendee that has a valid email address.

Here are some screenshots of the new messages...

Singleton Partial Day Event

Singleton Complete Day Event

Recurring Daily Event

Recurring Weekly Event

Recurring Bi-Weekly Event

Recurring Month Event with Absolute Date

Recurring Monthly Event with Relative Date

[st3iny]

LGTM! Extensive unit tests are great.