Skip to content

fix(files): also trigger new tab on file name middle click - #45571

Merged
skjnldsv merged 1 commit into
masterfrom
fix/files-middle-click
Jun 12, 2024
Merged

fix(files): also trigger new tab on file name middle click#45571
skjnldsv merged 1 commit into
masterfrom
fix/files-middle-click

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

@skjnldsvskjnldsv added bug 3. to review Waiting for reviews feature: files papercut Annoying recurring UX issue with possibly simple fix. labels May 29, 2024
@skjnldsvskjnldsv added this to the Nextcloud 30 milestone May 29, 2024
@skjnldsv
skjnldsv requested review from a team and ShGKmeMay 29, 2024 17:16
@skjnldsvskjnldsv self-assigned this May 29, 2024
@skjnldsv
skjnldsv requested review from Pytal, sorbaugh and szaimen and removed request for a teamMay 29, 2024 17:16
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

ShGKme

This comment was marked as outdated.

@skjnldsv

This comment was marked as resolved.

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

Ah, no! Now I do remember!
We do indeed have different links, that was how it was before.
We can discuss the default link expectations like Julius said, but as a fix, I think we should still merge this PR (after the auxclick adjusting).

If we want to remove the default click-to-download behaviour is a different topic in itself @ShGKme :)

@skjnldsv

skjnldsv commented May 30, 2024

Copy link
Copy Markdown
MemberAuthor

Alright, I tested on safari and it works!

  • if I remove the auxclick it fails on chrome
  • the click seems to only work on safari

So leaving them both is the way 👍
Please review again @ShGKme, and let's open a ticket afterwards to discuss the default link for 30 and above 👍

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested in a Chromium based browser on Windows and seems to work :)

@ShGKmeShGKme left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Safari 16 and Safari 17, both testing cloud and real MacBook.

Although MDN and caniuse say this event is not supported on Safari completely, it works fine on both list and grid with the middle button click.

But @click.middle would avoid the need to check event.button 👀

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/compile rebase-amend /

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv
skjnldsv merged commit 6ec6c1f into masterJun 12, 2024
@skjnldsv
skjnldsv deleted the fix/files-middle-click branch June 12, 2024 14:31
@artonge

Copy link
Copy Markdown
Collaborator

I think this also make the right-click trigger the default action

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: filespapercutAnnoying recurring UX issue with possibly simple fix.regression

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Bug]: Files app doesn't open middle-clicked file/folder in new browser tab since Nextcloud 28

4 participants

@skjnldsv@artonge@ShGKme@szaimen