Uh oh!
There was an error while loading. Please reload this page.
fix(files): also trigger new tab on file name middle click - #45571
Conversation
skjnldsv
commented
May 29, 2024
/backport to stable29 |
skjnldsv
commented
May 29, 2024
/backport to stable28 |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
commented
May 30, 2024
Ah, no! Now I do remember! If we want to remove the default click-to-download behaviour is a different topic in itself @ShGKme :) |
Alright, I tested on safari and it works!
So leaving them both is the way 👍 |
szaimen
left a comment
There was a problem hiding this comment.
Just tested in a Chromium based browser on Windows and seems to work :)
There was a problem hiding this comment.
Tested on Safari 16 and Safari 17, both testing cloud and real MacBook.
Although MDN and caniuse say this event is not supported on Safari completely, it works fine on both list and grid with the middle button click.
But @click.middle would avoid the need to check event.button 👀
skjnldsv
commented
Jun 12, 2024
/compile rebase-amend / |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
ffd0c9d to
a094ac0Compareartonge
commented
Jun 13, 2024
I think this also make the right-click trigger the default action |
Fix#44994