Skip to content

Bump select2 from v3 to v4 - #45628

Closed
drjoeycadieux wants to merge 5 commits into
nextcloud:masterfrom
drjoeycadieux:patch-1
Closed

Bump select2 from v3 to v4#45628
drjoeycadieux wants to merge 5 commits into
nextcloud:masterfrom
drjoeycadieux:patch-1

Conversation

@drjoeycadieux

Copy link
Copy Markdown

I update the select2 version to 4.0.8 in the package.json

  • Resolves: #

Summary

TODO

  • ...

Checklist

I update the select2 version to 4.0.8 in the package.json
Signed-off-by: Joey Cadieux <instructor.joeycadieux@gmail.com>
@ChristophWurst

Copy link
Copy Markdown
Member

See #35294

@ChristophWurst
ChristophWurst marked this pull request as draft June 3, 2024 06:04
@ChristophWurstChristophWurst changed the title Update package.jsonBump select2 from v3 to v4Jun 3, 2024
@drjoeycadieux
drjoeycadieux marked this pull request as ready for review June 5, 2024 14:30
@skjnldsv

Copy link
Copy Markdown
Member

I think we're removing it as legacy code 🙈
@susnux ?

@susnux

Copy link
Copy Markdown
Contributor

Yes we are currently removing the last places where it is used. I would not updated this package untested as it currently might break user ldap and other legacy stuff.

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@drjoeycadieux

Copy link
Copy Markdown
Author

Sorry, I'm here.

@blizzzblizzz mentioned this pull request Jul 30, 2024
@joshtrichards

Copy link
Copy Markdown
Member

Related overview: #1831 (though it looks to need updating)

@blizzzblizzz mentioned this pull request Aug 1, 2024
This was referenced Aug 5, 2024
@skjnldsvskjnldsv mentioned this pull request Aug 13, 2024
@blizzzblizzz mentioned this pull request Jan 8, 2025
This was referenced Jan 14, 2025
This was referenced Jan 21, 2025
@blizzzblizzz mentioned this pull request Jan 29, 2025
1 task
@blizzzblizzz modified the milestones: Nextcloud 31, Nextcloud 32Jan 29, 2025
@nextcloud-botnextcloud-bot mentioned this pull request Aug 22, 2025
@drjoeycadieux
drjoeycadieux requested review from a team as code ownersAugust 24, 2025 22:41
@drjoeycadieux
drjoeycadieux requested review from Altahrim, icewind1991, skjnldsv, susnux, szaimen and yemkareems and removed request for a teamAugust 24, 2025 22:41
@skjnldsv

Copy link
Copy Markdown
Member

Following both my and susnux comment, I'd prefer to close this PR, we will not update this lib as the very few leftovers usage of it are scheduled for removal.
If you would like to help, we'll gladly help you reviewing your PR to remove our select2 dependency :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@drjoeycadieux@ChristophWurst@skjnldsv@susnux@joshtrichards@blizzz@solracsf