Uh oh!
There was an error while loading. Please reload this page.
fix(caldav): stricter default calendar checks - #45667
Merged
Merged
Conversation
st3iny
commented
Jun 5, 2024
MemberAuthor
/backport to stable29 |
st3inyforce-pushed
the
fix/caldav/strict-default-calendar-checks
branch
from
June 5, 2024 07:11
9db8a35 to
3d5e847Comparest3iny
marked this pull request as ready for review
June 5, 2024 07:13
ChristophWurst
approved these changes
Jun 5, 2024
st3inyforce-pushed
the
fix/caldav/strict-default-calendar-checks
branch
from
June 5, 2024 07:27
3d5e847 to
a0d8728Comparest3iny
commented
Jun 5, 2024
MemberAuthor
I just realized that the fallback propFind method is also broken, when a task list is on top. So we have to do the same checks in our schedule plugin, too. I'll push another commit and some tests. |
| $objectTree, | ||
| $this->databaseConnection, | ||
| $this->userSession->getUser() | ||
| $this->userSession->getUser(), |
Check notice
Code scanning / Psalm
PossiblyNullArgument
| $this->server->tree, | ||
| \OC::$server->getDatabaseConnection(), | ||
| \OC::$server->getUserSession()->getUser() | ||
| \OC::$server->getUserSession()->getUser(), |
Check notice
Code scanning / Psalm
PossiblyNullArgument
| $this->server->tree, | ||
| \OC::$server->getDatabaseConnection(), | ||
| \OC::$server->getUserSession()->getUser() | ||
| \OC::$server->getUserSession()->getUser(), |
Check notice
Code scanning / Psalm
DeprecatedMethod
Reject calendars that - are subscriptions - are not writable - are shared with a user - are deleted - don't support VEVENTs Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3inyforce-pushed
the
fix/caldav/strict-default-calendar-checks
branch
from
July 22, 2024 13:24
a635a94 to
cbea787CompareUh oh!
There was an error while loading. Please reload this page.
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject calendars that
Checklist