Skip to content

fix(files_sharing): fix parsing of remote shares - #45698

Merged
skjnldsv merged 6 commits into
masterfrom
fix/files-remote-shares
Jun 12, 2024
Merged

fix(files_sharing): fix parsing of remote shares#45698
skjnldsv merged 6 commits into
masterfrom
fix/files-remote-shares

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Jun 6, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Fix#44318

  • Also fix various missing data for external shares
  • And also fix avatar for remote shares (+ dark avatar support)

Pending shares

BeforeAfter
2024-06-06_19-41_12024-06-06_19-41_2

Files list

BeforeAfter
2024-06-06_19-412024-06-06_19-42

@skjnldsvskjnldsv added this to the Nextcloud 30 milestone Jun 6, 2024
@skjnldsvskjnldsv self-assigned this Jun 6, 2024
github-advanced-security[bot]
github-advanced-securityAI found potential problems Jun 6, 2024
View reviewed changes
Comment threadapps/dav/lib/Connector/Sabre/SharesPlugin.php Fixed
Comment threadcore/Controller/AvatarController.php Fixed
@skjnldsvskjnldsv mentioned this pull request Jun 6, 2024
Closed
@skjnldsvskjnldsv changed the title fix(files_sgaring): fix parsing of remote sharesfix(files_shring): fix parsing of remote sharesJun 6, 2024
@skjnldsv
skjnldsv requested review from a team, ArtificialOwl, Pytal, artonge, nfebe, sorbaugh and szaimen and removed request for a teamJune 6, 2024 17:39
@skjnldsv
skjnldsvforce-pushed the fix/files-remote-shares branch from 29fd7ed to 8817417CompareJune 6, 2024 17:41
@skjnldsv
skjnldsv requested review from come-nc and removed request for sorbaughJune 6, 2024 17:43
github-advanced-security[bot]
github-advanced-securityAI found potential problems Jun 6, 2024
View reviewed changes
Comment threadcore/Controller/AvatarController.php Fixed
Comment threadcore/Controller/AvatarController.php Fixed
@AndyScherzingerAndyScherzinger changed the title fix(files_shring): fix parsing of remote sharesfix(files_sharing): fix parsing of remote sharesJun 6, 2024
@szaimen
szaimen removed their request for review June 6, 2024 20:01
@skjnldsv
skjnldsvforce-pushed the fix/files-remote-shares branch from 630e27c to 2211e6dCompareJune 6, 2024 20:04
@provokateurin
provokateurin self-requested a review as a code ownerJune 7, 2024 10:09
come-nc
come-nc reviewed Jun 10, 2024
View reviewed changes
Comment threadapps/dav/lib/Connector/Sabre/SharesPlugin.php
Comment threadapps/dav/lib/Connector/Sabre/SharesPlugin.php
Comment threadapps/dav/lib/Server.php Outdated
@skjnldsv
fix(files_sharing): fix parsing of remote shares
a0a3656
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
fix(core): allow guest avatar fallback
fb11672
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsvand others added 4 commits June 12, 2024 10:27
@skjnldsv
fix(dav): also return shared-with-me shares data
4a77fe3
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
fix(files_sharing): dark avatar support
8bed232
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@provokateurin@skjnldsv
fix(core): Return X-NC-IsCustomAvatar for guest avatars too
c8e7678
Signed-off-by: provokateurin <kate@provokateurin.de>
@skjnldsv
chore: compile assets
00803f5
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
skjnldsv requested a review from come-ncJune 12, 2024 08:28
@skjnldsv
skjnldsvforce-pushed the fix/files-remote-shares branch from dddc173 to 00803f5CompareJune 12, 2024 08:28
@skjnldsv
skjnldsv merged commit 4c32ab7 into masterJun 12, 2024
@skjnldsv
skjnldsv deleted the fix/files-remote-shares branch June 12, 2024 11:02
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Jun 12, 2024
@skjnldsv

skjnldsv commented Jun 12, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@skjnldsv

skjnldsv commented Jun 12, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@backportbotbackportbotBot mentioned this pull request Jun 12, 2024
Merged
2 tasks
@backportbotbackportbotBot mentioned this pull request Jun 12, 2024
Merged
2 tasks
@SystemKeeperSystemKeeper mentioned this pull request Jun 12, 2024
Closed
@nickvergessennickvergessen mentioned this pull request Jun 13, 2024
Merged
3 tasks
@juliusknorr

juliusknorr commented Jul 15, 2024

Copy link
Copy Markdown
Member

This seems to have added running some more heavy queries twice, filed at #46546

@blizzzblizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzingerAndyScherzingerAndyScherzinger approved these changes
@artongeartongeartonge approved these changes
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-frontend
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@PytalPytalAwaiting requested review from Pytal
@provokateurinprovokateurinAwaiting requested review from provokateurinprovokateurin is a code owner
@come-nccome-ncAwaiting requested review from come-nc

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: filesfeature: sharing

Projects

None yet

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

[Bug]: Remote shares are not listed in share views

7 participants

@skjnldsv@juliusknorr@AndyScherzinger@artonge@github-advanced-security@come-nc@provokateurin