Skip to content

feat(files): Implement files list filters - #45708

Merged
susnux merged 6 commits into
masterfrom
feat/files-filters
Jul 25, 2024
Merged

feat(files): Implement files list filters#45708
susnux merged 6 commits into
masterfrom
feat/files-filters

Conversation

@susnux

@susnuxsusnux commented Jun 7, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Current state:

Bildschirmaufnahme_20240724_201030.webm
Details Old state:
Screencast_20240607_141239.webm

TODO

Not related but there are some visual issues, those will be fixed with next nextcloud-vue update (size of the user select etc).

  • Implement "people" filter
  • Design
  • Tests (follow up)

Checklist

@susnuxsusnux added this to the Nextcloud 30 milestone Jun 7, 2024
@susnuxsusnux self-assigned this Jun 7, 2024
@sorbaughsorbaugh mentioned this pull request Jul 3, 2024
Closed
@susnux
susnuxforce-pushed the feat/files-filters branch from 337ba7c to f0599d0CompareJuly 24, 2024 18:25
@susnuxsusnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 24, 2024
@susnux
susnux marked this pull request as ready for review July 24, 2024 18:28
@susnux
susnux requested a review from skjnldsv as a code ownerJuly 24, 2024 18:28
AndyScherzinger
AndyScherzinger approved these changes Jul 24, 2024
View reviewed changes

@AndyScherzingerAndyScherzinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@AndyScherzingerAndyScherzinger mentioned this pull request Jul 24, 2024
Merged
skjnldsv
skjnldsv reviewed Jul 25, 2024
View reviewed changes
Comment threadapps/files/src/eventbus.d.ts Outdated
skjnldsv
skjnldsv reviewed Jul 25, 2024
View reviewed changes
Comment threadapps/files/src/views/FilesList.vue Outdated
skjnldsv
skjnldsv reviewed Jul 25, 2024
View reviewed changes
Comment threadpackage.json Outdated
skjnldsv
skjnldsv reviewed Jul 25, 2024
View reviewed changes
Comment threadapps/files/src/store/filters.ts Outdated
skjnldsv
skjnldsv reviewed Jul 25, 2024
View reviewed changes
Comment threadapps/files/src/store/filters.ts Outdated
@susnux
susnuxforce-pushed the feat/files-filters branch 2 times, most recently from 608f2c4 to 1160fc4CompareJuly 25, 2024 10:48
@susnux
susnux requested a review from skjnldsvJuly 25, 2024 10:49
@susnux
susnuxforce-pushed the feat/files-filters branch from 1160fc4 to 1d6b91cCompareJuly 25, 2024 11:07
skjnldsv
skjnldsv approved these changes Jul 25, 2024
View reviewed changes

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very nice work!!! 🤩

@susnux
susnuxforce-pushed the feat/files-filters branch from 1d6b91c to 565e018CompareJuly 25, 2024 15:16
@susnux
feat(files): Allow to add file list filters
968d412
This adds sticky file list filters above the file list.
Those filters are used to filter the directory content and thus filter the file list.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the feat/files-filters branch from 565e018 to 7602427CompareJuly 25, 2024 17:18
susnuxand others added 5 commits July 25, 2024 19:33
@susnux@skjnldsv
feat(files): Implement files list filters for name, modified time and…
842c21f
… type
Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor: Make route parameters accessible using composables to reuse
aad0976
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
feat(files_sharing): Add file list filter to filter by owner / sharee
1fc6b79
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
test: Add cypress tests for file list filtering
2c0e2cc
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
66f77b5
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the feat/files-filters branch from 7602427 to 66f77b5CompareJuly 25, 2024 17:33
@susnux
susnux merged commit 97ea957 into masterJul 25, 2024
@susnux
susnux deleted the feat/files-filters branch July 25, 2024 18:12
@juliusknorrjuliusknorr mentioned this pull request Aug 3, 2024
Closed
@skjnldsvskjnldsv mentioned this pull request Aug 7, 2024
Closed
This was referenced Aug 7, 2024
Closed
Closed
@PytalPytal mentioned this pull request Aug 13, 2024
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzingerAndyScherzingerAndyScherzinger approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@jancborchardtjancborchardtAwaiting requested review from jancborchardt
@PytalPytalAwaiting requested review from Pytal
@marcoambrosinimarcoambrosiniAwaiting requested review from marcoambrosini
@nfebenfebeAwaiting requested review from nfebe
@sorbaughsorbaughAwaiting requested review from sorbaugh

Assignees

@susnuxsusnux

Labels

3. to reviewWaiting for reviewsenhancementfeature: files

Projects

📁 Files team
Status: ☑️ Done

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

Filetype filters on top of the files list (doc, pdf, jpg, ...)

4 participants

@susnux@AndyScherzinger@skjnldsv@sorbaugh