Uh oh!
There was an error while loading. Please reload this page.
fix(caldav): event links in shared calendar notifications - #45775
Merged
Conversation
st3iny
requested review from
ChristophWurst, miaulalala and tcitworld
as code ownersJune 11, 2024 08:10
ChristophWurst
approved these changes
Jun 11, 2024
st3inyforce-pushed
the
fix/caldav/event-notification-shared-calendars
branch
from
June 11, 2024 17:00
64bdf08 to
7a10312Comparest3iny
commented
Jun 11, 2024
MemberAuthor
/backport to stable29 |
st3iny
commented
Jun 11, 2024
MemberAuthor
/backport to stable28 |
st3iny
commented
Jun 11, 2024
MemberAuthor
/backport to stable27 |
st3iny
enabled auto-merge
June 11, 2024 17:03
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3inyforce-pushed
the
fix/caldav/event-notification-shared-calendars
branch
from
June 11, 2024 18:10
7a10312 to
3a975d0Compare4 tasks
Merged
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
The link in event notifications is invalid if a calendar is shared. An incoming shared calendar is belonging to sharee's principal with the custom name
<calendar>_shared_by_<sharer>.I implemented a hack to change the link in those cases to make the links in notifications work again.
How to reproduce the bug?
Here: Clicking the link redirects to Calendar and opens the event.
Master: Clicking the link redirects to Calendar and shows an empty content
Event does not exist.Checklist