Skip to content

fix(comments): Use proper icon components instead of icon classes to fix dark mode - #45867

Merged
AndyScherzinger merged 2 commits into
masterfrom
fix/comments-icons
Jun 14, 2024
Merged

fix(comments): Use proper icon components instead of icon classes to fix dark mode#45867
AndyScherzinger merged 2 commits into
masterfrom
fix/comments-icons

Conversation

@susnux

@susnuxsusnux commented Jun 13, 2024

Copy link
Copy Markdown
Contributor

Summary

When using the comments app with dark mode the icons are hard to see because they are all black.
This is fixed with using proper icon components.

Screenshots

beforeafter
Screenshot 2024-06-13 at 18-06-37 Files - NextcloudScreenshot 2024-06-13 at 18-12-13 img_3236 jpg - Nextcloud

Checklist

…fix dark mode
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

@susnux

Copy link
Copy Markdown
ContributorAuthor

/compile

@susnuxsusnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 13, 2024
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv

Copy link
Copy Markdown
Member

Awesome!!

@solracsf

solracsf commented Jul 11, 2024

Copy link
Copy Markdown
Member

@skjnldsv@susnux should this be re-backported to stable28 ?
Ref: #45881 and #45881 (comment)

@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

@skjnldsv

Copy link
Copy Markdown
Member

/backport to stable28

@backportbot

Copy link
Copy Markdown

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/45867/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 93650e08 f8095023
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45867/stable28

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/45867/stable28."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@susnux@skjnldsv@solracsf@AndyScherzinger@artonge@nextcloud-command