Uh oh!
There was an error while loading. Please reload this page.
fix: don't use custom certificate bundle if no customer certificates are configured - #45877
Merged
Conversation
icewind1991
requested review from
a team, ArtificialOwl, sorbaugh and yemkareems
and removed request for
a teamJune 14, 2024 11:36
icewind1991
commented
Jun 14, 2024
MemberAuthor
/backport to stable29 |
icewind1991
commented
Jun 14, 2024
MemberAuthor
/backport to stable28 |
icewind1991
commented
Jun 14, 2024
MemberAuthor
/backport to stable27 |
…are configured Signed-off-by: Robin Appelman <robin@icewind.nl>
blizzzforce-pushed
the
fix-default-cert-bundle-path
branch
from
June 14, 2024 14:27
2d5984e to
e140907Compareicewind1991
enabled auto-merge
June 17, 2024 13:03
artonge
approved these changes
Jun 17, 2024
yemkareems
approved these changes
Jun 24, 2024
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/45877/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick e1409071
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45877/stable29Error: Failed to push branch backport/45877/stable29: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
icewind1991
commented
Jun 24, 2024
MemberAuthor
/backport to stable29 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a basic logic error 🙈