Skip to content

ci: use precise ref for 3rdparty check - #45912

Merged
blizzz merged 1 commit into
masterfrom
fix/noid/3rdparty-check-ref
Jun 17, 2024
Merged

ci: use precise ref for 3rdparty check#45912
blizzz merged 1 commit into
masterfrom
fix/noid/3rdparty-check-ref

Conversation

@blizzz

Copy link
Copy Markdown
Member

On stable29 we get wrong results, because more branches meet "stable29"

$ git ls-remote https://github.com/nextcloud/3rdparty stable29 1706802f48993629baa7eb5520d098fed6dfb222 refs/heads/backport/1863/stable29
164fb3b7760f5cd2b9b5c1bdad7c74da1bcd3b68 refs/heads/stable29

Prefixing refs/heads/ solves this to provide the correct hash:

$ git ls-remote https://github.com/nextcloud/3rdparty refs/heads/stable29
164fb3b7760f5cd2b9b5c1bdad7c74da1bcd3b68 refs/heads/stable29

It will also work on master

$ git ls-remote https://github.com/nextcloud/3rdparty refs/heads/master
45d8fc9e09fbb4d3c4de5819afd9a6f72ce00f56 refs/heads/master

Provided the substitution still works 😅

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
blizzz requested review from a team, ArtificialOwl, nickvergessen, sorbaugh and yemkareems and removed request for a teamJune 17, 2024 09:28
@blizzzblizzz added 3. to review Waiting for reviews tests Related to tests labels Jun 17, 2024
@blizzz

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@blizzz

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@blizzz

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@blizzz

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

@blizzz

Copy link
Copy Markdown
MemberAuthor

/backport to stable25

@blizzz

Copy link
Copy Markdown
MemberAuthor

/backport to stable24

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewstestsRelated to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@blizzz@nickvergessen@solracsf