Uh oh!
There was an error while loading. Please reload this page.
Rename openFileInfo to fileInfo - #45963
Merged
Merged
Conversation
skjnldsv
approved these changes
Jun 19, 2024
skjnldsv
commented
Jun 19, 2024
Member
/backport to stable29 |
skjnldsv
commented
Jun 19, 2024
Member
/backport to stable28 |
skjnldsv
commented
Jun 19, 2024
Member
@ShGKme because we talked about this iirc |
ShGKme
approved these changes
Jun 19, 2024
ShGKme
left a comment
Contributor
There was a problem hiding this comment.
Thanks 💙
In which case do we have no fileid from route and initial state is required? Except the public sharing.
Uh oh!
There was an error while loading. Please reload this page.
artongeforce-pushed
the
artonge/fix/openfile
branch
from
June 19, 2024 09:19
b9c144f to
8a8a1c7Compareartonge
commented
Jun 19, 2024
CollaboratorAuthor
I don't remember, but I think this use case does not exists anymore with F2V. |
artonge
commented
Jun 19, 2024
CollaboratorAuthor
/compile / |
And check if openFile is set in the URL before opening a file. Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: Louis Chemineau <louis@chmn.me>
artongeforce-pushed
the
artonge/fix/openfile
branch
from
June 19, 2024 13:38
3ae00b6 to
59ea179Compareartonge
enabled auto-merge
June 19, 2024 14:53
skjnldsv
disabled auto-merge
June 19, 2024 15:04
This was referenced Jun 19, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And check if openFile is set in the URL before opening a file.