Skip to content

Use guzzle for addressbook federation - #46002

Merged
kesselb merged 2 commits into
masterfrom
debt/noid/use-new-http-client
Jun 25, 2024
Merged

Use guzzle for addressbook federation#46002
kesselb merged 2 commits into
masterfrom
debt/noid/use-new-http-client

Conversation

@kesselb

@kesselbkesselb commented Jun 20, 2024

Copy link
Copy Markdown
Contributor
  • Resolves: noid

Summary

  • Use guzzle as http client
  • Don't mock the service itself, but the dependencies.

TODO

  • CI
  • Review

Checklist

@kesselbkesselb added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Jun 20, 2024
@kesselbkesselb added this to the Nextcloud 30 milestone Jun 20, 2024
@kesselbkesselb self-assigned this Jun 20, 2024
@kesselb
kesselbforce-pushed the debt/noid/use-new-http-client branch from f5cba2e to 36b5ba6CompareJune 20, 2024 10:12
Comment threadapps/dav/lib/CardDAV/SyncService.php Fixed
@kesselb
kesselbforce-pushed the debt/noid/use-new-http-client branch from 36b5ba6 to 4cf184bCompareJune 20, 2024 11:00
@kesselb
kesselbforce-pushed the debt/noid/use-new-http-client branch from 4cf184b to 85b0772CompareJune 20, 2024 14:03
The request method is available since 29 and thus we can finally use the modern http client to send the report request for the addressbook sync.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
kesselbforce-pushed the debt/noid/use-new-http-client branch from 85b0772 to f73c5c4CompareJune 25, 2024 10:24
@kesselb
kesselb merged commit 9522719 into masterJun 25, 2024
@kesselb
kesselb deleted the debt/noid/use-new-http-client branch June 25, 2024 19:10
@kesselb

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kesselb@ChristophWurst@miaulalala@github-advanced-security