Skip to content

fix(FilesView): Update files view upon share creation/delete - #46030

Merged
nfebe merged 3 commits into
masterfrom
fix/44961/shared-state-file-list
Jun 25, 2024
Merged

fix(FilesView): Update files view upon share creation/delete#46030
nfebe merged 3 commits into
masterfrom
fix/44961/shared-state-file-list

Conversation

@nfebe

@nfebenfebe commented Jun 21, 2024•
edited by max-nextcloud
Loading

Copy link
Copy Markdown
Contributor

Summary

Before

Bildschirmaufzeichnung.vom.22.04.2024.13.14.03.webm

After

refresh-files-view.webm

@nfebenfebe added this to the Nextcloud 29.0.3 milestone Jun 21, 2024
@nfebe
nfebe requested review from Pytal, skjnldsv and susnuxJune 21, 2024 09:31
@nfebenfebe self-assigned this Jun 21, 2024
@blizzzblizzz mentioned this pull request Jun 21, 2024
Merged
@nfebe

nfebe commented Jun 21, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

@nfebe

nfebe commented Jun 21, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

susnux
susnux reviewed Jun 21, 2024
View reviewed changes
Comment threadapps/files_sharing/src/views/SharingDetailsTab.vue Outdated
susnux
susnux reviewed Jun 21, 2024
View reviewed changes
Comment threadapps/files_sharing/src/views/SharingDetailsTab.vue
susnux
susnux reviewed Jun 21, 2024
View reviewed changes
Comment threadapps/files_sharing/src/views/SharingDetailsTab.vue Outdated
susnux
susnux reviewed Jun 21, 2024
View reviewed changes
Comment threadapps/files_sharing/src/views/SharingDetailsTab.vue Outdated
@nfebe
nfebeforce-pushed the fix/44961/shared-state-file-list branch 4 times, most recently from 57ab1b4 to a10c018CompareJune 21, 2024 20:04
susnux
susnux approved these changes Jun 24, 2024
View reviewed changes
Comment threadapps/files_sharing/src/views/SharingDetailsTab.vue Outdated
Comment threadapps/files_sharing/src/views/SharingDetailsTab.vue Outdated
@nfebe
nfebeforce-pushed the fix/44961/shared-state-file-list branch from a10c018 to fc68cd6CompareJune 24, 2024 09:28
max-nextcloud
max-nextcloud reviewed Jun 25, 2024
View reviewed changes
Comment threadapps/files_sharing/src/views/SharingDetailsTab.vue
max-nextcloud
max-nextcloud reviewed Jun 25, 2024
View reviewed changes
Comment threadapps/files_sharing/src/views/SharingDetailsTab.vue Outdated
@max-nextcloud

max-nextcloud commented Jun 25, 2024

Copy link
Copy Markdown
Contributor

After adjusting the logger import sharing with alice works nicely.
However if I just create a link share the left side is still not updated.

Bildschirmaufzeichnung.vom.25.06.2024.06.06.20.webm

Would be nice to tackle that as well.

@nfebe
nfebeforce-pushed the fix/44961/shared-state-file-list branch from fc68cd6 to 5927e3cCompareJune 25, 2024 06:42
@szaimen

szaimen commented Jun 25, 2024

Copy link
Copy Markdown
Contributor

This also resolves #40263, I suppose?

@nfebe
nfebeforce-pushed the fix/44961/shared-state-file-list branch from 5927e3c to 02199b2CompareJune 25, 2024 11:26
max-nextcloud
max-nextcloud approved these changes Jun 25, 2024
View reviewed changes

@max-nextcloudmax-nextcloud left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried again... works like a charm now 🪄

Thanks! ❤️

nfebe added 2 commits June 25, 2024 18:16
@nfebe
fix(FilesView): Update files view upon share creation/delete
38b5987
Resolves : #44961
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe
refactor(SharingDetailsView): Use NC logger
f7527c3
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe
nfebeforce-pushed the fix/44961/shared-state-file-list branch from 02199b2 to f7527c3CompareJune 25, 2024 17:16
@nfebe

nfebe commented Jun 25, 2024

Copy link
Copy Markdown
ContributorAuthor

/compile

@nextcloud-command
chore(assets): Recompile assets
5746696
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe
nfebe merged commit f018222 into masterJun 25, 2024
@nfebe
nfebe deleted the fix/44961/shared-state-file-list branch June 25, 2024 19:51
This was referenced Jun 25, 2024
Merged
Merged
@blizzzblizzz mentioned this pull request Jul 24, 2024
Merged
@susnuxsusnux moved this from 🏗️ In progress to ☑️ Done in 📁 Files teamMar 14, 2025
@susnuxsusnux moved this from ☑️ Done to 🏗️ In progress in 📁 Files teamMar 14, 2025
@susnuxsusnux moved this from 🏗️ In progress to ☑️ Done in 📁 Files teamMar 14, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnuxsusnuxsusnux approved these changes
@max-nextcloudmax-nextcloudmax-nextcloud approved these changes
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@PytalPytalAwaiting requested review from Pytal

Assignees

@nfebenfebe

Labels

3. to reviewWaiting for reviewsfeature: filesfeature: sharing

Projects

📁 Files team
Status: ☑️ Done

Milestone

Nextcloud 29.0.4

Development

Successfully merging this pull request may close these issues.

[Bug]: Reflect shared state in file list after sharing without reload Share node change between sidebar and Files app

6 participants

@nfebe@max-nextcloud@szaimen@susnux@blizzz@nextcloud-command