Skip to content

fix: allows admin to edit global credentials - #46073

Merged
Altahrim merged 1 commit into
masterfrom
fix/save_global_credentials
Jun 25, 2024
Merged

fix: allows admin to edit global credentials#46073
Altahrim merged 1 commit into
masterfrom
fix/save_global_credentials

Conversation

@Altahrim

@AltahrimAltahrim commented Jun 24, 2024•
edited by AndyScherzinger
Loading

Copy link
Copy Markdown
Collaborator

Summary

It's not possible to save global credentials in external storage anymore.

Checklist

@AltahrimAltahrim self-assigned this Jun 24, 2024
github-advanced-security[bot]
github-advanced-securityAI found potential problems Jun 24, 2024
View reviewed changes
Comment threadapps/files_external/lib/Controller/AjaxController.php Fixed
Comment threadapps/files_external/lib/Controller/AjaxController.php Fixed
@Altahrim
fix: allows admin to edit global credentials
e93866f
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim
Altahrimforce-pushed the fix/save_global_credentials branch from ddd3ca0 to e93866fCompareJune 24, 2024 13:20
@Altahrim
Altahrim requested review from a team, nfebe, sorbaugh and yemkareems and removed request for a teamJune 24, 2024 13:21
@AltahrimAltahrim added this to the Nextcloud 30 milestone Jun 24, 2024
@Altahrim

Altahrim commented Jun 24, 2024

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable29

@Altahrim

Altahrim commented Jun 24, 2024

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable28

@Altahrim

Altahrim commented Jun 24, 2024

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable27

@Altahrim
Altahrim marked this pull request as ready for review June 24, 2024 13:24
@AltahrimAltahrim added the php Pull requests that update Php code label Jun 24, 2024
@Altahrim
Altahrim merged commit 369c552 into masterJun 25, 2024
@Altahrim
Altahrim deleted the fix/save_global_credentials branch June 25, 2024 07:48
This was referenced Jun 25, 2024
Merged
Merged
Merged
@blizzzblizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArtificialOwlArtificialOwlArtificialOwl approved these changes
@GretaDGretaDGretaD approved these changes
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-backend
@yemkareemsyemkareemsAwaiting requested review from yemkareemsyemkareems is a code owner automatically assigned from nextcloud/server-backend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@AltahrimAltahrim

Labels

bugphpPull requests that update Php code

Projects

None yet

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

4 participants

@Altahrim@ArtificialOwl@GretaD@github-advanced-security