Skip to content

fix(userstatus): Fix user status automation in real-life scenario - #46077

Merged
miaulalala merged 1 commit into
masterfrom
bugfix/noid/user-status-automation
Jun 25, 2024
Merged

fix(userstatus): Fix user status automation in real-life scenario#46077
miaulalala merged 1 commit into
masterfrom
bugfix/noid/user-status-automation

Conversation

@nickvergessen

@nickvergessennickvergessen commented Jun 24, 2024

Copy link
Copy Markdown
Member

Steps

  1. Set a user status (message, emoji or both)
  2. Create a meeting in the calendar
  3. Run cron jobs
  4. Check content of oc_user_status (See backup status of 1 and live status of 2)
  5. Set availability so it does not currently apply
  6. Run cron jobs
    1. Expected: Check content of oc_user_status (See backup status of 1 and live status DND of 5)
    2. Actual: Check content of oc_user_status (See backup status of 1 and live status of 2)

If you replace step 2 with doing a call, it worked already.
Also tested with OOO and that one also failed to overwrite the meeting status.

Checklist

@nickvergessennickvergessen added bug 3. to review Waiting for reviews feature: dav papercut Annoying recurring UX issue with possibly simple fix. feature: status labels Jun 24, 2024
@nickvergessennickvergessen added this to the Nextcloud 30 milestone Jun 24, 2024
@nickvergessennickvergessen self-assigned this Jun 24, 2024
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@nickvergessen
nickvergessenforce-pushed the bugfix/noid/user-status-automation branch from 6540e12 to 3402d98CompareJune 24, 2024 15:13
Comment threadapps/user_status/lib/Service/StatusService.php Fixed
Comment threadapps/user_status/lib/Service/StatusService.php Fixed

@AntreesyAntreesy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit. Tested with meeting / OOO and call / OOO

@nickvergessen
nickvergessenforce-pushed the bugfix/noid/user-status-automation branch from 3402d98 to ec5466dCompareJune 25, 2024 07:27
Order of applying:
- Out-of-office
- Availability
- Call
- Meeting
- User status
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the bugfix/noid/user-status-automation branch from ec5466d to 2c977d2CompareJune 25, 2024 07:29

@miaulalalamiaulalala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels a bit like the rules for https://www.ultra-watten.com/watten-regeln ahahaha

Nice one, thanks for fixing that

@miaulalala
miaulalala merged commit eed6216 into masterJun 25, 2024
@miaulalala
miaulalala deleted the bugfix/noid/user-status-automation branch June 25, 2024 09:32
@blizzzblizzz mentioned this pull request Jul 24, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: davfeature: statuspapercutAnnoying recurring UX issue with possibly simple fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen@miaulalala@github-advanced-security@Antreesy