Skip to content

fix(files_sharing): Also set the expiration date timezone during validation - #46097

Merged
artonge merged 1 commit into
masterfrom
artonge/fix/dont_override_expiration_date
Jun 26, 2024
Merged

fix(files_sharing): Also set the expiration date timezone during validation#46097
artonge merged 1 commit into
masterfrom
artonge/fix/dont_override_expiration_date

Conversation

@artonge

@artongeartonge commented Jun 25, 2024

Copy link
Copy Markdown
Collaborator

This is needed as we want to store the difference between the server's and the user's timezones.

Follow-up of #43428

@artonge
artonge requested review from Altahrim and nfebeJune 25, 2024 10:24
@artongeartonge self-assigned this Jun 25, 2024
@artongeartonge added bug 3. to review Waiting for reviews feature: sharing php Pull requests that update Php code labels Jun 25, 2024
@artongeartonge added this to the Nextcloud 30 milestone Jun 25, 2024
@artonge

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable29

@artonge

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable28

@artonge
artongeforce-pushed the artonge/fix/dont_override_expiration_date branch 4 times, most recently from 5630c33 to 0f56fb4CompareJune 25, 2024 13:07
@artongeartonge changed the title Do not update the timezone of the expiration date when validating itfix(files_sharing): Also set the expiration date timezone during validationJun 25, 2024

@nfebenfebe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

…s timezone
This is needed as we want to store the difference between the server's and the user's timezones.
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
artongeforce-pushed the artonge/fix/dont_override_expiration_date branch from 0f56fb4 to f5fd6c8CompareJune 26, 2024 10:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: sharingphpPull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@artonge@Altahrim@nfebe