Skip to content

fix(DAV): offset not applied - #46219

Merged
blizzz merged 1 commit into
masterfrom
fix/noid/infinit-BuildSocialSearchIndexBackgroundJob
Jul 1, 2024
Merged

fix(DAV): offset not applied#46219
blizzz merged 1 commit into
masterfrom
fix/noid/infinit-BuildSocialSearchIndexBackgroundJob

Conversation

@blizzz

Copy link
Copy Markdown
Member

Summary

with more than 100 results, this job may never finish

Question though: do we still need this job?

Checklist

with more than 100 results, this job may never finish
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzzblizzz added bug 3. to review Waiting for reviews labels Jul 1, 2024
@blizzz

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@blizzz

blizzz commented Jul 1, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

conflicts, did manually

@blizzzblizzz changed the title fix(BuildSocialSearchIndexBackgroundJob): offset not appliedfix(DAV): offset not appliedJul 1, 2024
@blizzz
blizzz requested a review from max-nextcloudJuly 1, 2024 12:41
->from('cards', 'c')
->orderBy('id', 'ASC')
->where($query->expr()->like('carddata', $query->createNamedParameter('%SOCIALPROFILE%')))
->andWhere($query->expr()->gt('id', $query->createNamedParameter((int)$offset, IQueryBuilder::PARAM_INT)))

Check notice

Code scanning / Psalm

RedundantCastGivenDocblockType

Redundant cast to int given docblock-provided type
@blizzz
blizzz merged commit 7bd2158 into masterJul 1, 2024
@blizzz
blizzz deleted the fix/noid/infinit-BuildSocialSearchIndexBackgroundJob branch July 1, 2024 16:37
@blizzz
blizzz restored the fix/noid/infinit-BuildSocialSearchIndexBackgroundJob branch July 8, 2024 20:27
@blizzz
blizzz deleted the fix/noid/infinit-BuildSocialSearchIndexBackgroundJob branch July 8, 2024 20:29
@blizzzblizzz mentioned this pull request Jul 24, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@blizzz@ChristophWurst@github-advanced-security@come-nc