Skip to content

fix(dav): Thrown forbidden error for authenticated user instead of no… - #46225

Merged
AndyScherzinger merged 1 commit into
masterfrom
fix/issue-11633
Jul 19, 2024
Merged

fix(dav): Thrown forbidden error for authenticated user instead of no…#46225
AndyScherzinger merged 1 commit into
masterfrom
fix/issue-11633

Conversation

@SebastianKrupinski

@SebastianKrupinskiSebastianKrupinski commented Jul 1, 2024

Copy link
Copy Markdown
Contributor

fix(dav): Thrown forbidden error for authenticated user instead of not found

@solracsfsolracsf added the 3. to review Waiting for reviews label Jul 1, 2024
@solracsfsolracsf added this to the Nextcloud 30 milestone Jul 1, 2024
github-advanced-security[bot]
github-advanced-securityAI found potential problems Jul 1, 2024
View reviewed changes
Comment threadapps/dav/lib/Connector/Sabre/DavAclPlugin.php Fixed
Comment threadapps/dav/lib/Connector/Sabre/DavAclPlugin.php Fixed
Comment threadapps/dav/lib/Connector/Sabre/DavAclPlugin.php Fixed
github-advanced-security[bot]
github-advanced-securityAI found potential problems Jul 2, 2024
View reviewed changes
Comment threadapps/dav/lib/Connector/Sabre/DavAclPlugin.php
)
);

if ($this->getCurrentUserPrincipal() === $node->getOwner()) {

Check notice

Code scanning / Psalm

PossiblyUndefinedMethod

Method Sabre\DAV\INode::getOwner does not exist
@SebastianKrupinski
fix(dav): Thrown forbidden error for authenticated user instead of no…
f5fcfb4
…t found
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinskiSebastianKrupinski self-assigned this Jul 18, 2024
@AndyScherzinger
AndyScherzinger merged commit 2e273e4 into masterJul 19, 2024
@AndyScherzinger
AndyScherzinger deleted the fix/issue-11633 branch July 19, 2024 17:00
@AndyScherzinger

AndyScherzinger commented Jul 19, 2024

Copy link
Copy Markdown
Member

/backport to stable29

@backportbotbackportbotBot mentioned this pull request Jul 19, 2024
Merged
@SebastianKrupinski

SebastianKrupinski commented Jul 19, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

@backportbotbackportbotBot mentioned this pull request Jul 19, 2024
Merged
@blizzzblizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@st3inyst3inyst3iny approved these changes
@miaulalalamiaulalalamiaulalala approved these changes
@hamza221hamza221hamza221 approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen

Assignees

@SebastianKrupinskiSebastianKrupinski

Labels

3. to reviewWaiting for reviews

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

CalDAV birthday calendar: modifying birthdays should return 403 instead of 404

8 participants

@SebastianKrupinski@AndyScherzinger@ChristophWurst@st3iny@miaulalala@hamza221@github-advanced-security@solracsf