Skip to content

fix(files): Correctly center the checkbox's background in grid view - #46358

Merged
AndyScherzinger merged 2 commits into
masterfrom
artonge/fix/checkbox_background
Jul 8, 2024
Merged

fix(files): Correctly center the checkbox's background in grid view#46358
AndyScherzinger merged 2 commits into
masterfrom
artonge/fix/checkbox_background

Conversation

@artonge

@artongeartonge commented Jul 8, 2024

Copy link
Copy Markdown
Collaborator

Background set to red for the screenshots to make it more obvious

BeforeAfter
Screenshot from 2024-07-08 17-34-52Screenshot from 2024-07-08 17-34-30

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
artonge requested a review from skjnldsv as a code ownerJuly 8, 2024 15:35
@artongeartonge self-assigned this Jul 8, 2024
@artonge

Copy link
Copy Markdown
CollaboratorAuthor

/compile /

@artongeartonge added bug 4. to release Ready to be released and/or waiting for tests to finish feature: files javascript labels Jul 8, 2024
@artongeartonge added this to the Nextcloud 30 milestone Jul 8, 2024
@artonge
artonge requested a review from susnuxJuly 8, 2024 15:36
@susnux

Copy link
Copy Markdown
Contributor

Probably the background should be added to the component directly?

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

@AndyScherzingerAndyScherzinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@AndyScherzinger
AndyScherzinger merged commit 9b2d195 into masterJul 8, 2024
@AndyScherzinger
AndyScherzinger deleted the artonge/fix/checkbox_background branch July 8, 2024 19:12
@blizzzblizzz mentioned this pull request Jul 24, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: filesjavascript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@artonge@susnux@AndyScherzinger@nextcloud-command