Skip to content

[stable29] fix(ci): Correctly check for assets that need compilation - #46469

Merged
nickvergessen merged 3 commits into
stable29from
backport/46468/stable29
Jul 12, 2024
Merged

[stable29] fix(ci): Correctly check for assets that need compilation#46469
nickvergessen merged 3 commits into
stable29from
backport/46468/stable29

Conversation

@backportbot

@backportbotbackportbotBot commented Jul 12, 2024•
edited
Loading

Copy link
Copy Markdown

Backport of #46468

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbotbackportbotBot added the 3. to review Waiting for reviews label Jul 12, 2024
@backportbotbackportbotBot added this to the Nextcloud 29.0.4 milestone Jul 12, 2024
@nickvergessen

nickvergessen commented Jul 12, 2024

Copy link
Copy Markdown
Member

/compile /

@susnuxsusnux changed the title [stable29] [stable28] fix(ci): Use low runners were possible[stable29] fix(ci): Use low runners were possibleJul 12, 2024
@SystemKeeperSystemKeeper changed the title [stable29] fix(ci): Use low runners were possible[stable29] fix(ci): Correctly check for assets that need compilationJul 12, 2024
@nickvergessen

nickvergessen commented Jul 12, 2024

Copy link
Copy Markdown
Member

@nickvergessennickvergessen mentioned this pull request Jul 12, 2024
Merged
4 tasks
nickvergessenand others added 3 commits July 12, 2024 15:13
@nickvergessen
fix(CI): Ensure we recompile when needed
cb5bd60
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nextcloud-command@nickvergessen
chore(assets): Recompile assets
cde3d99
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nickvergessen
fix(CI): Require compilation check when touching version.php
54328eb
NPM is using version.php as app version and that seems to be part of the dist files now
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the backport/46468/stable29 branch from d2890f6 to 54328ebCompareJuly 12, 2024 13:13
@nickvergessen
nickvergessen merged commit 37043b6 into stable29Jul 12, 2024
@nickvergessen
nickvergessen deleted the backport/46468/stable29 branch July 12, 2024 14:17
@AltahrimAltahrim mentioned this pull request Jul 17, 2024
Merged
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SystemKeeperSystemKeeperSystemKeeper approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen

Assignees

@SystemKeeperSystemKeeper

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 29.0.4

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@SystemKeeper@nextcloud-command