Skip to content

fix(caldav): Throw 403 Forbidden Error instead of 500 Internal Server… - #46593

Merged
ChristophWurst merged 1 commit into
masterfrom
fix/issue-30514
Jul 18, 2024
Merged

fix(caldav): Throw 403 Forbidden Error instead of 500 Internal Server…#46593
ChristophWurst merged 1 commit into
masterfrom
fix/issue-30514

Conversation

@SebastianKrupinski

@SebastianKrupinskiSebastianKrupinski commented Jul 17, 2024

Copy link
Copy Markdown
Contributor

@SebastianKrupinskiSebastianKrupinski self-assigned this Jul 17, 2024
ChristophWurst
ChristophWurst approved these changes Jul 17, 2024
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

Comment threadapps/dav/lib/CalDAV/CalDavBackend.php
ChristophWurst
ChristophWurst reviewed Jul 17, 2024
View reviewed changes
Comment threadapps/dav/lib/CalDAV/CalDavBackend.php Outdated
@SebastianKrupinskiSebastianKrupinski added the 3. to review Waiting for reviews label Jul 17, 2024
@SebastianKrupinski
fix(caldav): Throw 403 Forbidden Error instead of 500 Internal Server…
0f3d05a
… Error
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@ChristophWurst
ChristophWurst merged commit 1de5adf into masterJul 18, 2024
@ChristophWurst
ChristophWurst deleted the fix/issue-30514 branch July 18, 2024 08:16
@ChristophWurst

ChristophWurst commented Jul 18, 2024

Copy link
Copy Markdown
Member

/backport to stable29

@ChristophWurst

ChristophWurst commented Jul 18, 2024

Copy link
Copy Markdown
Member

/backport to stable28

@backportbotbackportbotBot mentioned this pull request Jul 18, 2024
Merged
@backportbotbackportbotBot mentioned this pull request Jul 18, 2024
Merged
@SebastianKrupinskiSebastianKrupinski added this to the Nextcloud 30 milestone Jul 23, 2024
@blizzzblizzz mentioned this pull request Jul 24, 2024
Merged
@FurriousFoxFurriousFox mentioned this pull request Jun 15, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@miaulalalamiaulalalamiaulalala approved these changes
@st3inyst3inyAwaiting requested review from st3iny
@kesselbkesselbAwaiting requested review from kesselb
@tcitworldtcitworldAwaiting requested review from tcitworldtcitworld is a code owner

Assignees

@SebastianKrupinskiSebastianKrupinski

Labels

3. to reviewWaiting for reviews

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

[CalDAV] Nextcloud returns HTTP 500 instead of 403 when POSTing an event without valid instances

3 participants

@SebastianKrupinski@ChristophWurst@miaulalala