Skip to content

[stable28] fix: Pass the mountpoint target user to storages without owner - #46680

Merged
AndyScherzinger merged 2 commits into
stable28from
backport/44294/stable28
Sep 3, 2024
Merged

[stable28] fix: Pass the mountpoint target user to storages without owner#46680
AndyScherzinger merged 2 commits into
stable28from
backport/44294/stable28

Conversation

@backportbot

@backportbotbackportbotBot commented Jul 22, 2024

Copy link
Copy Markdown

Backport of #44294

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbotbackportbotBot added bug 3. to review Waiting for reviews labels Jul 22, 2024
@backportbotbackportbotBot added this to the Nextcloud 28.0.9 milestone Jul 22, 2024
@backportbot
backportbotBotforce-pushed the backport/44294/stable28 branch from 8b31c0e to 53d6d60CompareJuly 22, 2024 12:54
@skjnldsvskjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 27, 2024
@juliusknorr
juliusknorrforce-pushed the backport/44294/stable28 branch from 53d6d60 to 74fd470CompareAugust 6, 2024 20:53
@juliusknorr
juliusknorr marked this pull request as ready for review August 6, 2024 20:53
@AltahrimAltahrim mentioned this pull request Aug 8, 2024
3 tasks
@solracsfsolracsf added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 8, 2024
@skjnldsvskjnldsv mentioned this pull request Aug 20, 2024
12 tasks
Storages that do not have a dedicated owner (e.g. groupfolders, external
storages) currently always assume the current session user as the owner.
This leads to several issues when there is no user session but a node is
obtained through a user folder.
In order to have the correct user available we need to pass the user
that is used to setup a mountpoint along to the storage layer as we
generally assume that an owner is available for those.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Comment threadlib/public/Files/Storage/IStorage.php Outdated
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
AndyScherzinger merged commit 208bbf3 into stable28Sep 3, 2024
@AndyScherzinger
AndyScherzinger deleted the backport/44294/stable28 branch September 3, 2024 15:46
@blizzzblizzz mentioned this pull request Sep 4, 2024
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@juliusknorr@come-nc@AndyScherzinger@solracsf@skjnldsv