Skip to content

Update @nextcloud/files to 3.6.0 and fix display name handling of folders (breadcrumbs and filename) - #46690

Merged
susnux merged 4 commits into
masterfrom
fix/files-displayname
Jul 25, 2024
Merged

Update @nextcloud/files to 3.6.0 and fix display name handling of folders (breadcrumbs and filename)#46690
susnux merged 4 commits into
masterfrom
fix/files-displayname

Conversation

@susnux

@susnuxsusnux commented Jul 22, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  1. Update to current version 3.6.0 of nextcloud-files (drop duplicated code)
  2. For folders do not cut-off the extension as folders do not have extensions they are part of the filename, this fixes names of folder in the file list and in the bread crumbs

Checklist

@susnuxsusnux added this to the Nextcloud 30 milestone Jul 22, 2024
@susnux
susnux requested review from Pytal, artonge and nfebeJuly 22, 2024 16:14
@susnux
susnux requested a review from skjnldsv as a code ownerJuly 22, 2024 16:14
@susnux

susnux commented Jul 22, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

@susnux

susnux commented Jul 22, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

@susnux
susnuxforce-pushed the fix/files-displayname branch from b263035 to f01848cCompareJuly 22, 2024 16:16
@susnux
susnux requested a review from sorbaughJuly 22, 2024 16:19
@susnuxsusnux changed the title Update @nextcloud/files to 3.6.0 and fix display name handling of folders (bread crumbs and filename)Update @nextcloud/files to 3.6.0 and fix display name handling of folders (breadcrumbs and filename)Jul 22, 2024
@susnuxsusnux mentioned this pull request Jul 22, 2024
Closed
artonge
artonge reviewed Jul 23, 2024
View reviewed changes
Comment threadapps/files/src/components/FileEntryMixin.ts
@susnux
susnuxforce-pushed the fix/files-displayname branch from f01848c to ed54f64CompareJuly 24, 2024 13:49
@susnux

susnux commented Jul 24, 2024

Copy link
Copy Markdown
ContributorAuthor

/compile

@susnuxsusnux mentioned this pull request Jul 24, 2024
Closed
susnuxand others added 4 commits July 25, 2024 01:24
@susnux
chore(deps): Update @nextcloud/files to v3.6.0
f95d826
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(files): Do not split filename into base and extension for fol…
5dc8e06
…ders
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix: Ensure displayname is a string
80d797e
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@nextcloud-command@susnux
chore(assets): Recompile assets
fe1aa83
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
susnuxforce-pushed the fix/files-displayname branch from 607a594 to fe1aa83CompareJuly 24, 2024 23:26
@susnux
susnux merged commit d843d67 into masterJul 25, 2024
@susnux
susnux deleted the fix/files-displayname branch July 25, 2024 00:09
This was referenced Jul 25, 2024
Merged
Merged
@susnuxsusnux mentioned this pull request Jul 25, 2024
Closed
4 tasks
@blizzzblizzz mentioned this pull request Jul 25, 2024
Merged
@joshtrichardsjoshtrichards mentioned this pull request Aug 30, 2024
Closed
8 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artongeartongeartonge approved these changes
@nfebenfebenfebe approved these changes
@PytalPytalAwaiting requested review from Pytal
@skjnldsvskjnldsvAwaiting requested review from skjnldsvskjnldsv is a code owner
@sorbaughsorbaughAwaiting requested review from sorbaugh

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: files

Projects

None yet

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

[Bug]: Renamed files are not refreshed in the web interface + side weird issues [Bug]: new name of renamed file only shown after page reload

4 participants

@susnux@artonge@nfebe@nextcloud-command