Uh oh!
There was an error while loading. Please reload this page.
[stable25] fix(cron): Log long running jobs - #46716
Closed
backportbot[bot] wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
skjnldsv
approved these changes
Aug 2, 2024
AndyScherzinger
commented
Aug 2, 2024
Member
@ChristophWurst php 7.4 linter fails (for a reasons I would say): |
susnux
reviewed
Aug 2, 2024
Comment on lines
+159
to
+165
| $logLevel = match (true) { | ||
| $timeSpent > $cronInterval * 128 => \OCP\ILogger::FATAL, | ||
| $timeSpent > $cronInterval * 64 => \OCP\ILogger::ERROR, | ||
| $timeSpent > $cronInterval * 16 => \OCP\ILogger::WARN, | ||
| $timeSpent > $cronInterval * 8 => \OCP\ILogger::INFO, | ||
| default => \OCP\ILogger::DEBUG, | ||
| }; |
Contributor
There was a problem hiding this comment.
This does not work match was introduced with PHP 8.0 so you need to use switch-case
Contributor
There was a problem hiding this comment.
@ChristophWurst looks like backporting won't be possible here :(
Member
@AndyScherzinger@sorbaugh I did not intend to get this merged. @marinofaggiana needed a patch to debug a production system, for which this PR is sufficient as long as it's not used with old PHP. See #45804 (comment). We can close the PR. 25 is EOL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #45855