Skip to content

fix: add a try and catch for delete versioning - #46749

Merged
GretaD merged 1 commit into
masterfrom
fix/background-job-error
Jul 25, 2024
Merged

fix: add a try and catch for delete versioning#46749
GretaD merged 1 commit into
masterfrom
fix/background-job-error

Conversation

@GretaD

@GretaDGretaD commented Jul 25, 2024•
edited by solracsf
Loading

Copy link
Copy Markdown
Contributor

Summary

TODO

  • ...

Checklist

@GretaDGretaD added the 3. to review Waiting for reviews label Jul 25, 2024
@GretaD
GretaD requested a review from artongeJuly 25, 2024 11:41
@GretaDGretaD self-assigned this Jul 25, 2024
@GretaD

GretaD commented Jul 25, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

@GretaD

GretaD commented Jul 25, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

artonge
artonge reviewed Jul 25, 2024
View reviewed changes
Comment threadapps/files_versions/lib/Storage.php Outdated
@GretaD
GretaD requested a review from artongeJuly 25, 2024 12:17
artonge
artonge approved these changes Jul 25, 2024
View reviewed changes

@artongeartonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested and it works. :)

@GretaD
fix: add a try and catch for delete versioning
26d2288
Signed-off-by: greta <gretadoci@gmail.com>
@GretaD
GretaDforce-pushed the fix/background-job-error branch from 66f7400 to 26d2288CompareJuly 25, 2024 12:46
@GretaD
GretaD enabled auto-merge July 25, 2024 12:47
@GretaD
GretaD disabled auto-merge July 25, 2024 14:41
@GretaD
GretaD merged commit d5bb37a into masterJul 25, 2024
@GretaD
GretaD deleted the fix/background-job-error branch July 25, 2024 14:49
This was referenced Jul 25, 2024
Merged
Merged
@AndyScherzingerAndyScherzinger added this to the Nextcloud 30 milestone Jul 25, 2024
@blizzzblizzz mentioned this pull request Jul 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@artongeartongeartonge approved these changes

Assignees

@GretaDGretaD

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

[Bug]: Error while running background job ExpireVersions - Missing permissions to delete version

4 participants

@GretaD@ChristophWurst@artonge@AndyScherzinger