Skip to content

[stable28] fix(files_sharing): open-in-files should open a folder and not the parent - #46754

Merged
skjnldsv merged 5 commits into
stable28from
backport/46648/stable28
Aug 2, 2024
Merged

[stable28] fix(files_sharing): open-in-files should open a folder and not the parent#46754
skjnldsv merged 5 commits into
stable28from
backport/46648/stable28

Conversation

@backportbot

@backportbotbackportbotBot commented Jul 25, 2024

Copy link
Copy Markdown

Backport of #46648

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsvskjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 27, 2024
@skjnldsv
skjnldsvforce-pushed the backport/46648/stable28 branch from 70f5e15 to 381036cCompareAugust 2, 2024 07:06
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Aug 2, 2024
@skjnldsv
skjnldsv marked this pull request as ready for review August 2, 2024 07:07
@skjnldsv
skjnldsvforce-pushed the backport/46648/stable28 branch from 0fa81f2 to e984059CompareAugust 2, 2024 07:26
@skjnldsv

Copy link
Copy Markdown
Member

/compile rebase-amend /

@skjnldsv
skjnldsvforce-pushed the backport/46648/stable28 branch 2 times, most recently from 1a2ae17 to 4467521CompareAugust 2, 2024 12:39
…parent
For files this behavior is fine, but for folders the folder itself should be opened.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv
skjnldsvforce-pushed the backport/46648/stable28 branch from 4467521 to 9e81a0dCompareAugust 2, 2024 13:31
@skjnldsv
skjnldsv enabled auto-merge August 2, 2024 14:19
@skjnldsv

Copy link
Copy Markdown
Member
 1) files_sharing: Files view
opens a shared folder when clicking on it:
AssertionError: Timed out retrying after 4000ms: Expected to find element: `[data-cy-files-sharing-share-editor-action="save"]`, but never found it.
at eval (webpack://nextcloud/./cypress/e2e/files_sharing/FilesSharingUtils.ts:17:7)
at Context.eval (webpack://nextcloud/./cypress/e2e/files_sharing/files-shares-view.cy.ts:23:20)

Too tired, I fixed too many backports already today 😓

skjnldsvand others added 2 commits August 2, 2024 18:53
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
susnuxforce-pushed the backport/46648/stable28 branch from 9e81a0d to fdd1e39CompareAugust 2, 2024 16:53
@susnux

Copy link
Copy Markdown
Contributor

Caused by an incomplete backport of some other old PR. Fixed it :)

@skjnldsv
skjnldsv disabled auto-merge August 2, 2024 17:43
@skjnldsv
skjnldsv merged commit e655d44 into stable28Aug 2, 2024
@skjnldsv
skjnldsv deleted the backport/46648/stable28 branch August 2, 2024 17:43
@AltahrimAltahrim mentioned this pull request Aug 8, 2024
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@susnux@artonge