Uh oh!
There was an error while loading. Please reload this page.
fix(styles): Make sure footer with legal links is shown correctly - #46784
Merged
Conversation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
commented
Jul 26, 2024
ContributorAuthor
/backport to stable29 |
susnux
commented
Jul 26, 2024
ContributorAuthor
/backport to stable28 |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
szaimen
approved these changes
Jul 26, 2024
szaimen
left a comment
Contributor
There was a problem hiding this comment.
Looks good from the screenshots but didnt test and didnt review the code
skjnldsv
approved these changes
Jul 27, 2024
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
skjnldsv
commented
Jul 27, 2024
Member
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This was referenced Jul 27, 2024
4 tasks
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix public pages footer height. If there are legal links or a signup link or both we need different heights of the footer.
Otherwise the footer content will be clipped and overlay the app.
Adjusted colors in the screen shots to make clear what is which element:
Checklist