Skip to content

refactor(theming): Replace security annotations with respective attributes - #46819

Merged
provokateurin merged 1 commit into
masterfrom
refactor/theming/security-attributes
Jul 29, 2024
Merged

refactor(theming): Replace security annotations with respective attributes#46819
provokateurin merged 1 commit into
masterfrom
refactor/theming/security-attributes

Conversation

@provokateurin

Copy link
Copy Markdown
Member

Summary

Follow-up to #46606

Checklist

@provokateurinprovokateurin added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jul 27, 2024
@provokateurinprovokateurin added this to the Nextcloud 30 milestone Jul 27, 2024
@provokateurin
provokateurinforce-pushed the refactor/theming/security-attributes branch from 9be6257 to fbe83f5CompareJuly 27, 2024 19:35
…butes
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin
provokateurinforce-pushed the refactor/theming/security-attributes branch from fbe83f5 to 79d9f2eCompareJuly 27, 2024 20:40
@provokateurin
provokateurin merged commit 20e054c into masterJul 29, 2024
@provokateurin
provokateurin deleted the refactor/theming/security-attributes branch July 29, 2024 06:57
*/
#[PublicPage]
#[NoCSRFRequired]
#[BruteForceProtection('manifest')]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing PSALM to fail on master.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I thought I had fixed all of them. Let me quickly fix this

@blizzzblizzz mentioned this pull request Jul 30, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews♻️ refactorRefactor code (not a bug fix, not a feature just refactoring)technical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@provokateurin@juliusknorr@solracsf@skjnldsv