Skip to content

turn LDAP's treat remnants as disabled feature config-independent - #46992

Open
blizzz wants to merge 4 commits into
masterfrom
fix/noid/ldap-remnants-as-disabled-global
Open

turn LDAP's treat remnants as disabled feature config-independent#46992
blizzz wants to merge 4 commits into
masterfrom
fix/noid/ldap-remnants-as-disabled-global

Conversation

@blizzz

@blizzzblizzz commented Aug 2, 2024

Copy link
Copy Markdown
Member

Summary

Since former LDAP users cannot be bound to a server configuration anymore (or theoretically belong to more than one) this feature has to be config independent. This PR:

  • changes the existing logic from config-bound to app-global
  • including web interface changes
  • has a migration step to set the new values based on the old ones – one previous activation enables it for the whole LDAP backend

A backport to 28 will need further adjustments as IAppConfig was only introduced in 29.

Screenshot_20240802_181949

Checklist

@blizzzblizzz added this to the Nextcloud 30 milestone Aug 2, 2024
@blizzz
blizzz requested review from a team, artonge, come-nc and yemkareems and removed request for a teamAugust 2, 2024 16:21
@blizzz
blizzzforce-pushed the fix/noid/ldap-remnants-as-disabled-global branch from 65f3833 to 6a0351eCompareAugust 2, 2024 17:01
Comment threadapps/user_ldap/lib/Migration/RearrangeMarkRemnantsAsDisabled.php Outdated
Comment threadapps/user_ldap/lib/User_Proxy.php Outdated
Comment threadapps/user_ldap/lib/Configuration.php
This was referenced Aug 5, 2024
@skjnldsvskjnldsv mentioned this pull request Aug 13, 2024
@skjnldsvskjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 29, 2024
@blizzzblizzz mentioned this pull request Jan 8, 2025
This was referenced Jan 14, 2025
This was referenced Jan 21, 2025
@blizzzblizzz mentioned this pull request Jan 29, 2025
1 task
@blizzzblizzz modified the milestones: Nextcloud 31, Nextcloud 32Jan 29, 2025
@blizzz
blizzzforce-pushed the fix/noid/ldap-remnants-as-disabled-global branch from 6a0351e to 6876d4fCompareJune 12, 2025 17:36
@blizzz
blizzz requested review from a team as code ownersJune 12, 2025 17:36
This was referenced Aug 25, 2025
This was referenced Sep 2, 2025
@nextcloud-botnextcloud-bot mentioned this pull request Sep 10, 2025
@nextcloud-botnextcloud-bot mentioned this pull request Sep 18, 2025
This was referenced Sep 25, 2025
@come-nc

Copy link
Copy Markdown
Contributor

@blizzz It would be nice to rebase this on the vue rewrite and remove the static vars. Then we can merge.

This was referenced Jan 7, 2026
This was referenced Jan 14, 2026
@nextcloud-botnextcloud-bot mentioned this pull request Jan 22, 2026
This was referenced Jan 29, 2026
This was referenced Feb 11, 2026
@blizzzblizzz modified the milestones: Nextcloud 33, Nextcloud 34Feb 16, 2026
@nextcloud-botnextcloud-bot mentioned this pull request May 27, 2026
@nextcloud-botnextcloud-bot mentioned this pull request Jun 4, 2026
This was referenced Jun 5, 2026
@susnuxsusnux removed this from the Nextcloud 34.0.1 milestone Jun 9, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: ldap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@blizzz@come-nc@joshtrichards@susnux@skjnldsv@nextcloud-bot