Skip to content

fix(files): Correctly handle open file URL query - #47015

Merged
juliusknorr merged 3 commits into
masterfrom
fix/open-file
Aug 3, 2024
Merged

fix(files): Correctly handle open file URL query#47015
juliusknorr merged 3 commits into
masterfrom
fix/open-file

Conversation

@susnux

@susnuxsusnux commented Aug 3, 2024

Copy link
Copy Markdown
Contributor

Summary

There were 3 issues:

  1. The openfile is set on the query not as a param
  2. It is called openfile not openFile
  3. When redirecting to a file the viewer should open by default, so we need to set the openfile query on the redirect.

Sadly we can not really test this as the viewer is not included.

Screen recording

Bildschirmaufnahme_20240803_141453.webm

Checklist

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
… open by default
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@juliusknorr

Copy link
Copy Markdown
Member

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliusknorr
juliusknorr merged commit 50e6108 into masterAug 3, 2024
@juliusknorr
juliusknorr deleted the fix/open-file branch August 3, 2024 19:08
@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@susnux@juliusknorr@skjnldsv@nextcloud-command