Uh oh!
There was an error while loading. Please reload this page.
[stable28] fix(files): Correctly validate new node name - #47035
Merged
Conversation
susnuxforce-pushed
the
backport/46774/stable28
branch
from
August 21, 2024 00:08
7f3b516 to
c4ec230Comparesusnux
marked this pull request as ready for review
August 21, 2024 00:08
susnux
approved these changes
Aug 21, 2024
susnuxforce-pushed
the
backport/46774/stable28
branch
from
August 21, 2024 00:13
c4ec230 to
50a404cComparenfebe
approved these changes
Aug 21, 2024
skjnldsv
commented
Aug 21, 2024
Member
Restarted cypress, but failure looked suspiciously related |
skjnldsv
enabled auto-merge
August 21, 2024 07:58
skjnldsv
commented
Aug 21, 2024
Member
Failure related |
DaphneMuller
commented
Aug 21, 2024
Contributor
@skjnldsv what is the next step here? |
skjnldsv
commented
Aug 21, 2024
Member
Fixing the tests 🤭🤭 |
DaphneMuller
commented
Aug 21, 2024
Contributor
@skjnldsv sorry I don't fully get what you mean. The reason I ask is because this is for a support ticket that is meeting the SLA soon. Can this please be merged? Or can you give me a date when it can to be merged? Or otherwise tell me a next step concretely (who does what when) |
susnux
commented
Aug 21, 2024
Contributor
@DaphneMuller should be in next maintenance releases |
susnuxforce-pushed
the
backport/46774/stable28
branch
from
August 21, 2024 13:37
50a404c to
27538b5Comparesusnux
commented
Aug 21, 2024
Contributor
drone is unrelated |
susnux
disabled auto-merge
August 21, 2024 15:15
* Resolves#45409 This includes two fixes: 1. The name in the "new node" dialog is correctly selected (e.g. `file.txt` only `file` is selected by default), to allow quick naming 2. `@nextcloud/files` functions for filename validation are used, this allows to use new Nextcloud 30 capabilities (e.g. reserved names) Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
backport/46774/stable28
branch
from
August 27, 2024 10:44
27538b5 to
adbffd6Comparesusnux
enabled auto-merge
August 27, 2024 10:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #46767
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.