Skip to content

fix: Ensure database connection is setup when getting group details - #47065

Merged
skjnldsv merged 1 commit into
masterfrom
fix/group-oc
Aug 6, 2024
Merged

fix: Ensure database connection is setup when getting group details#47065
skjnldsv merged 1 commit into
masterfrom
fix/group-oc

Conversation

@susnux

Copy link
Copy Markdown
Contributor

Summary

This class is super weird, I like the fixme since 2016 ^^
Noticed this will running circles:sync on Nextcloud 28

An unhandled exception has been thrown:
Error: Call to a member function getQueryBuilder() on null in /var/www/html/lib/private/Group/Database.php:543
Stack trace:
#0 /var/www/html/lib/private/Group/Manager.php(233): OC\Group\Database->getGroupsDetails(Array)
#1 /var/www/html/lib/private/Group/Manager.php(324): OC\Group\Manager->getGroupsObjects(Array)
#2 /var/www/html/apps/circles/lib/Service/SyncService.php(261): OC\Group\Manager->search('')
#3 /var/www/html/apps/circles/lib/Service/SyncService.php(174): OCA\Circles\Service\SyncService->syncNextcloudGroups()
#4 /var/www/html/apps/circles/lib/Command/CirclesSync.php(146): OCA\Circles\Service\SyncService->sync(63)
#5 /var/www/html/3rdparty/symfony/console/Command/Command.php(298): OCA\Circles\Command\CirclesSync->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#6 /var/www/html/core/Command/Base.php(177): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#7 /var/www/html/3rdparty/symfony/console/Application.php(1040): OC\Core\Command\Base->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#8 /var/www/html/3rdparty/symfony/console/Application.php(301): Symfony\Component\Console\Application->doRunCommand(Object(OCA\Circles\Command\CirclesSync), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#9 /var/www/html/3rdparty/symfony/console/Application.php(171): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#10 /var/www/html/lib/private/Console/Application.php(213): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#11 /var/www/html/console.php(100): OC\Console\Application->run()
#12 /var/www/html/occ(11): require_once('/var/www/html/c...')

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnuxsusnux added bug 3. to review Waiting for reviews labels Aug 6, 2024
@susnux
susnux requested review from a team, ArtificialOwl, come-nc, icewind1991 and yemkareems and removed request for a teamAugust 6, 2024 11:43
@susnuxsusnux added this to the Nextcloud 30 milestone Aug 6, 2024
@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

@AltahrimAltahrim mentioned this pull request Aug 6, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@susnux@skjnldsv@yemkareems@come-nc