Skip to content

fix(systemtags): Correctly load tagged files in "tags"-files-view - #47120

Merged
AndyScherzinger merged 2 commits into
masterfrom
fix/systemtags
Aug 8, 2024
Merged

fix(systemtags): Correctly load tagged files in "tags"-files-view#47120
AndyScherzinger merged 2 commits into
masterfrom
fix/systemtags

Conversation

@susnux

Copy link
Copy Markdown
Contributor

When splitting the path it is /{ID} to the splitted array is ['', '{ID}'] -> we need to use the last part otherwise we only get 404.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

@susnux

Copy link
Copy Markdown
ContributorAuthor

/compile

@susnuxsusnux mentioned this pull request Aug 7, 2024
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv

Copy link
Copy Markdown
Member

We need tests for this 🙈

@AndyScherzinger

Copy link
Copy Markdown
Member

Merged to have it in Beta5 but created a follow-up at #47127 to have an issue for implementing tests

@susnux

Copy link
Copy Markdown
ContributorAuthor

We need tests for this 🙈

I am already writing some, but this was more urgent 😅

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@susnux@skjnldsv@AndyScherzinger@nextcloud-command